-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calypso CSS: refactor CSS reset and base styles #37020
Conversation
@@ -0,0 +1,150 @@ | |||
//@mixin calypso-reset { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need these to be in mixin, but it would make things easier for #36170 and (component) consumers outside Calypso.
@@ -28,11 +28,6 @@ | |||
box-sizing: border-box; | |||
overflow: hidden; | |||
|
|||
// I guess we dont want links to look like links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to _base.scss
but will need to check how that affects things outside .layout__content
— maybe leave be for now and loop back to it later. It's the only non-class-selector here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing outside .layout__content
is the Masterbar and things inside it, notably Notifications. Notifications have their own .wpnc__main a { text-decoration: none }
style, so they shouldn't get hurt by this change. I think it's good and safe move.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRed separately so that it's easier to test #37064
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope reset and base -styles so that it's possible to exclude them from some views.
I understand the need for scoping the base styles, but why reset? It would help to know the use case that requires the scoping feature. Or is it from the "someone might need it" bucket at this moment?
@@ -28,11 +28,6 @@ | |||
box-sizing: border-box; | |||
overflow: hidden; | |||
|
|||
// I guess we dont want links to look like links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing outside .layout__content
is the Masterbar and things inside it, notably Notifications. Notifications have their own .wpnc__main a { text-decoration: none }
style, so they shouldn't get hurt by this change. I think it's good and safe move.
763f7a9
to
b88e1ad
Compare
Pretty much everything from this has been handled in separate PRs or problems worked out in other ways, so I'll close. Calypso stylesets definetely need some more work but new PRs are better for that. :-) |
Goal: scope CSS reset and base calypso styles so that it's possible to exclude them from
/gutenboarding
section.Specifically, I'm addressing these two issues from #36170 (comment):
Here are some Calypso overrides previous "Gutenberg in Calypso" had to do.
Changes proposed in this Pull Request
client/assets/stylesheets/layout
, leavingclient/assets/stylesheets/*.scss
only for entry fileslayout
folder, leaving shared for only scss files that don't produce any visible CSS when importedgrow
animation to_animations.scss
_base.scss
file, goal is to strip down generic "main" file away eventuallyhtml.gr__calypso_localhost
as a temporary example selector — it'll be something else later on.README.md
I'll PR some of this separately for easier review & testing:
a
CSS reset to main style #37064Testing instructions
/onboarding
looks great, eh?