-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove block align to avoid error message have different width #5546
Remove block align to avoid error message have different width #5546
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/course-list #5546 +/- ##
======================================================
Coverage 44.61% 44.62%
Complexity 8788 8788
======================================================
Files 420 420
Lines 31356 31361 +5
Branches 239 240 +1
======================================================
+ Hits 13991 13995 +4
- Misses 17191 17192 +1
Partials 174 174
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is also removing the ability to control the categories alignment, ideally, we should keep the maximum possible customizations to our users.
I would suggest adding an extra element/class when the message is displayed and control it with CSS.
@gabrielcaires that is also a solution, my concern is that adding the align property can cause more trouble that the benefit. Also, I don't see in the block settings anywhere that you can change the alignment even if it is enabled : Is there some other place where it can be changed? |
@LavaGolem The feature is displayed, above the block when you select. |
@gabrielcaires so instead of removing align option from a block, I'm setting a align center by default. This will enable to users to change the alignment but we don't care if the decision to do it is on an Invalid usage block. Commit 2bdc7b7 |
fd2b8c8
to
2bdc7b7
Compare
Fixes #5517
Changes proposed in this Pull Request
align: true
from block settingshere
Testing instructions