Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for when course list filter is added to non course list blocks #5617

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Sep 9, 2022

Fixes #5616

Changes proposed in this Pull Request

  • Fixed alignment of the warning message shown when course list filter block is added outside of course list block in editor
  • Fixed showing error message in frontend when course list filter block is added and saved outside of course list block

Testing instructions

  • Add Course List filter block in different places other than inside course list block
  • Save and check both front and backend
  • Make sure nothing is being rendered in frontend for the filter blocks
  • In the editor, the error messages are shown with proper alignment

@Imran92 Imran92 requested a review from a team September 9, 2022 10:57
@Imran92 Imran92 self-assigned this Sep 9, 2022
@Imran92 Imran92 linked an issue Sep 9, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #5617 (8c8c771) into feature/course-list (68cb4e1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##             feature/course-list    #5617      +/-   ##
=========================================================
+ Coverage                  44.69%   44.72%   +0.02%     
+ Complexity                  8859     8840      -19     
=========================================================
  Files                        427      426       -1     
  Lines                      31636    31574      -62     
  Branches                     245      245              
=========================================================
- Hits                       14139    14120      -19     
+ Misses                     17319    17276      -43     
  Partials                     178      178              
Impacted Files Coverage Δ
...ourse-list-filter-block/course-list-filter-edit.js 57.14% <100.00%> (+2.14%) ⬆️
...rse-list/class-sensei-course-list-filter-block.php 91.11% <100.00%> (+0.63%) ⬆️
includes/class-sensei-quiz.php 59.04% <0.00%> (-0.14%) ⬇️
includes/class-sensei-autoloader.php 17.50% <0.00%> (ø)
...ss-sensei-reports-overview-list-table-students.php 42.26% <0.00%> (ø)
...ports/class-sensei-no-users-table-relationship.php
includes/class-sensei.php 27.33% <0.00%> (+0.06%) ⬆️
includes/class-sensei-notices.php 56.81% <0.00%> (+1.00%) ⬆️
...ss-sensei-reports-overview-list-table-abstract.php 64.66% <0.00%> (+1.67%) ⬆️
...sensei-reports-overview-data-provider-students.php 90.90% <0.00%> (+10.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cb4e1...8c8c771. Read the comment docs.

Copy link
Collaborator

@donnapep donnapep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 👍🏻

@Imran92 Imran92 merged commit a798f97 into feature/course-list Sep 9, 2022
@Imran92 Imran92 deleted the add/handle-course-list-filter-added-to-non-course-list-block branch September 9, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Course List Filter block being added outside of Course List block
2 participants