fix: use synced attributes for ListContainer directly #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
pushed a commit
that referenced
this pull request
Jun 21, 2021
# [2.0.0-alpha.1](v1.2.1...v2.0.0-alpha.1) (2021-06-21) ### Bug Fixes * activation PHP warning ([#70](#70)) ([29b0a34](29b0a34)) * failing npm ci command ([f509f36](f509f36)) * guard against nonexistent meta object ([#66](#66)) ([c821a09](c821a09)) * missing condition for block appender in list container ([#74](#74)) ([2c49896](2c49896)) * newspack_blocks support slug ([a2bda56](a2bda56)) * remove material packages ([b489015](b489015)) * use synced attributes for ListContainer directly ([#73](#73)) ([f8641a7](f8641a7)) * use value property of selection from AutocompleteWithSuggestions ([#61](#61)) ([c7c4cea](c7c4cea)) * util for checking post type on new posts ([fb61530](fb61530)) * warning about default meta value ([16af17b](16af17b)) * wp_insert_post filter name and theme_mod filter ([5befca7](5befca7)) ### Features * add a new global setting and post option to hide date ([#57](#57)) ([896f68f](896f68f)) * add revisions support for listings ([42d04d2](42d04d2)) * add settings for individual listing type URL slugs ([d78a3f7](d78a3f7)), closes [#41](#41) * better integration with Newspack Theme features ([823f66a](823f66a)) * child and related listings UI ([#58](#58)) ([06aff81](06aff81)) * convert legacy custom terms to regular post terms ([#67](#67)) ([a2fcf84](a2fcf84)) * CSV importer script ([#51](#51)) ([ffbea00](ffbea00)) * flush permalinks automatically if updating slug option ([988521e](988521e)) * support Newspack Sponsors for listings ([#65](#65)) ([7d2ef64](7d2ef64)) * update cpt icon and block icons ([7b59032](7b59032)), closes [#49](#49) * update price block to use placeholder and large font size ([#71](#71)) ([710f34c](710f34c)) * use post categories and tags for all listing post types ([#39](#39)) ([f223053](f223053)), closes [#32](#32) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.
|
🎉 This PR is included in version 2.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jun 22, 2021
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
Jul 19, 2021
# 1.0.0-alpha.1 (2021-07-19) ### Bug Fixes * avoid meta sync update error ([#95](#95)) ([cab16aa](cab16aa)) * do not register post-specific sidebars in widgets page ([#93](#93)) ([7716775](7716775)) * editor errors with reusable blocks ([#89](#89)) ([fdc46d3](fdc46d3)) * errors and bugs related to WP 5.8 ([#83](#83)) ([90da6c5](90da6c5)) * force alpha rebuild ([acc2075](acc2075)) * minor bug fixes ([#21](#21)) ([5f90bc7](5f90bc7)) * missing condition for block appender in list container ([#74](#74)) ([2c49896](2c49896)) * syncing attributes from curated list block to inner blocks ([#64](#64)) ([cdbc0bb](cdbc0bb)) * use synced attributes for ListContainer directly ([#73](#73)) ([f8641a7](f8641a7)) ### Features * add block patterns ([#23](#23)) ([a273a40](a273a40)) * bump max number of items per list from 20 to 50 ([#97](#97)) ([009deab](009deab)) * initial post type and block setup ([#1](#1)) ([47dc0c1](47dc0c1)) * listing taxonomies and query mode ([#6](#6)) ([528e1e5](528e1e5)) * more block patterns (real estate, classified ads) ([#84](#84)) ([a51f5af](a51f5af)) * new Curated List block, block pattern, and map functionality ([#3](#3)) ([9be6e7e](9be6e7e)) * remove borders and padding in editor to match front-end styles ([#14](#14)) ([6c47a17](6c47a17)) * v2 release (#85) ([748810d](748810d)), closes [#85](#85) [#40](#40) [#39](#39) [#32](#32) [#41](#41) [#49](#49) [#43](#43) [#56](#56) [#51](#51) [#57](#57) [#61](#61) [#67](#67) [#60](#60) [#70](#70) [#65](#65) [#71](#71) [#66](#66) [#58](#58) [#77](#77) [#81](#81) ### BREAKING CHANGES * This feature will deprecate existing custom taxonomies, so any existing terms for those taxonomies will be lost. To fix, we can convert terms from the deprecated taxonomies to standard post categories/tags via a migration script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
#63 refactored how we pass block attributes from the parent Curated List block to its inner list container and individual listing blocks by automatically setting attributes for its children directly. However, the list container block is still attempting to look up attributes from its parent instead of using its own synced attributes, which results in a JS error in certain situations.
Slightly related, I also removed the condition for the parent block needing to be selected in order to show a block appender button, which is something that used the faulty logic but we shouldn't need to refactor because we've already removed the condition in phase 2 PRs.
How to test the changes in this Pull Request:
Somewhat difficult to replicate locally, as a curated list in query mode needs have been created on a plugin build prior to #63. Then, after updating the plugin to the latest release, you may experience a block crash in the editor and a JS console error about
can't read property queryOptions of undefined.The error was reported on this page and I've confirmed that patching the plugin installed on that site has fixed the issue.
Other information: