fix: editor errors with reusable blocks (#89)

* fix: editor error message in reusable blocks * fix: editor display of multiple categories
Automattic · Jul 6, 2021 · fdc46d3 · fdc46d3
1 parent 748810d
commit fdc46d3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/blocks/listing/listing.js b/src/blocks/listing/listing.js
@@ -54,7 +54,7 @@ export const Listing = ( { attributes, error, post } ) => {
 							{ category.map( ( _category, index ) => (
 								<Fragment key="index">
 									{ decodeEntities( _category.name ) }
-									{ index + 1 < _category.length && ', ' }
+									{ index + 1 < category.length && ', ' }
 								</Fragment>
 							) ) }
 						</div>

diff --git a/src/editor/shadow-taxonomies/child-listings.js b/src/editor/shadow-taxonomies/child-listings.js
@@ -264,11 +264,11 @@ const ChildListingsComponent = ( { hideChildren, postId, updateMetaValue } ) =>
 
 const mapStateToProps = select => {
 	const { getCurrentPostId, getEditedPostAttribute } = select( 'core/editor' );
-	const meta = getEditedPostAttribute( 'meta' );
+	const meta = getEditedPostAttribute( 'meta' ) || {};
 
 	return {
 		getEditedPostAttribute,
-		hideChildren: meta.newspack_listings_hide_children,
+		hideChildren: meta?.newspack_listings_hide_children,
 		postId: getCurrentPostId(),
 	};
 };

diff --git a/src/editor/shadow-taxonomies/parent-listings.js b/src/editor/shadow-taxonomies/parent-listings.js
@@ -333,11 +333,11 @@ const ParentListingsComponent = ( { hideParents, postId, updateMetaValue } ) =>
 
 const mapStateToProps = select => {
 	const { getCurrentPostId, getEditedPostAttribute } = select( 'core/editor' );
-	const meta = getEditedPostAttribute( 'meta' );
+	const meta = getEditedPostAttribute( 'meta' ) || {};
 
 	return {
 		getEditedPostAttribute,
-		hideParents: meta.newspack_listings_hide_parents,
+		hideParents: meta?.newspack_listings_hide_parents,
 		postId: getCurrentPostId(),
 	};
 };