Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix up header includes using "./" and "../" and other misc. clean-up #585

Merged
merged 10 commits into from
Jun 14, 2020
Merged

fix up header includes using "./" and "../" and other misc. clean-up #585

merged 10 commits into from
Jun 14, 2020

Conversation

mattyjams
Copy link
Contributor

@mattyjams mattyjams commented Jun 10, 2020 •
edited
Loading

This fixes up the remaining instances where headers were being included with a path using ./ or ../. While I was in there, I also addressed a few other coding guidelines issues for the header includes in those files.

@kxl-adsk kxl-adsk requested a review from murphyeoin June 10, 2020 19:22
@kxl-adsk kxl-adsk added the build Related to building maya-usd repository label Jun 10, 2020
@kxl-adsk kxl-adsk requested a review from HamedSabri-adsk June 10, 2020 19:23
@HamedSabri-adsk
Copy link
Contributor

@mattyjams lgtm! I still see in bunch of other places the traces of ../ ./. Can you please address them in this PR?

e.g

https://github.com/mattyjams/maya-usd/blob/pr/fix_relative_include_paths_in_AL_plugins/plugin/al/lib/AL_USDMaya/AL/usdmaya/fileio/AnimationTranslator.h

https://github.com/mattyjams/maya-usd/blob/pr/fix_relative_include_paths_in_AL_plugins/plugin/al/lib/AL_USDMaya/AL/usdmaya/fileio/ImportTranslator.h

https://github.com/mattyjams/maya-usd/blob/pr/fix_relative_include_paths_in_AL_plugins/plugin/al/lib/AL_USDMaya/AL/usdmaya/fileio/translators/DgNodeTranslator.h

mattyjams added 10 commits June 10, 2020 21:44
@mattyjams mattyjams force-pushed the pr/fix_relative_include_paths_in_AL_plugins branch from 61d5f82 to e71c72f Compare June 11, 2020 05:14
@mattyjams mattyjams changed the title fix up header includes using "./" and other misc. clean-up fix up header includes using "./" and "../" and other misc. clean-up Jun 11, 2020
@mattyjams
Copy link
Contributor Author

@mattyjams lgtm! I still see in bunch of other places the traces of ../ ./. Can you please address them in this PR?

e.g

https://github.com/mattyjams/maya-usd/blob/pr/fix_relative_include_paths_in_AL_plugins/plugin/al/lib/AL_USDMaya/AL/usdmaya/fileio/AnimationTranslator.h

https://github.com/mattyjams/maya-usd/blob/pr/fix_relative_include_paths_in_AL_plugins/plugin/al/lib/AL_USDMaya/AL/usdmaya/fileio/ImportTranslator.h

https://github.com/mattyjams/maya-usd/blob/pr/fix_relative_include_paths_in_AL_plugins/plugin/al/lib/AL_USDMaya/AL/usdmaya/fileio/translators/DgNodeTranslator.h

Ahh, good catch @HamedSabri-adsk. Sorry, my grep'ing missed those.

That added a bunch more files in plugin/al that are addressed in 99fcff5, and two files in mayaUsd/ufe addressed in bdd436f.

HamedSabri-adsk
HamedSabri-adsk approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@HamedSabri-adsk HamedSabri-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgmt! Thank you.

@kxl-adsk kxl-adsk merged commit 14e89f9 into Autodesk:dev Jun 14, 2020
@mattyjams mattyjams deleted the pr/fix_relative_include_paths_in_AL_plugins branch June 15, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HamedSabri-adsk HamedSabri-adsk HamedSabri-adsk approved these changes

@murphyeoin murphyeoin Awaiting requested review from murphyeoin

Assignees
No one assigned
Labels
build Related to building maya-usd repository
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattyjams @HamedSabri-adsk @kxl-adsk