MAYA-123181 - As a user, I'd like my prims to be in untextured mode when in a Display Layer #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vlasovi
commented
Sep 14, 2022
- Introducing support for two simultaneous compiled material networks in HdVP2Material: Full and Untextured. Before, only one one network might be compiled at a time.
- Fixing mixed multi-viewport styles, which were broken lately, all the while keeping the optimal performance.
- Adding a separate representation for Untextured draw style with support from meshes, curves and points
- Supporting display layer's "texturing" attribute
…d to compiled material network into a separate entity: CompiledNetwork. This is required to proceed in future to having two separate compiled networks: full and untextured
…l and Untextured. This commit contains some temporary code in proxyRenderDelegate.cpp that will be removed in later commits of this PR.
…mizations introduced by William Krick some time ago. Those changes needed for proper implementation of untextured mode
…memory overwrite inside MVertexBuffer::commit call, by using an alternative MVertexBuffer::update function.
|
@JGamache-autodesk This is a big PR with a lot of changes. It might be easier for you to go through individual commits |
JGamache-autodesk
approved these changes
Sep 15, 2022
| if (inUntexturedMode) { | ||
| untexturedNetworkMap = vtMatResource.UncheckedGet<HdMaterialNetworkMap>(); | ||
| ConvertNetworkMapToUntextured(untexturedNetworkMap); | ||
| // full network is synced only if required by display style |
There was a problem hiding this comment.
Unclear why the untextured network is always synced. Especially when we want the full network for the textured Repr.
There was a problem hiding this comment.
The default viewport style in Maya is untextured, so I thought of untextured material network as default as well, especially since it's lightweight compared to the other one. However, you are right and technically we shouldn't be forced to always sync it.
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.