-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated NURBS curve export for widths and knots attributes #2326
Updated NURBS curve export for widths and knots attributes #2326
Conversation
Looks like it's building and passing tests. macOS failing with:
Seems that Clang is just being fussy about warnings. I'll have a fix up in the morning (Sydney time), but should be reviewable. |
1206d7b
to
b8e70a0
Compare
The comment at the top says "updating the ADSK plugin's NURBS curve export of knots to avoid adding extra knots in non-wrapping curves (i.e. do not copy the first and last knots in the exported vector)", but according to the USD documentation there should be extra knots for both periodic and non-periodic curves: https://graphics.pixar.com/usd/dev/api/class_usd_geom_nurbs_curves.html#details |
This PR aims to continue the alignment between the AL and ADSK plugins' export functionality, updating the ADSK plugin's NURBS curve export of
knots
to avoid adding extra knots in non-wrapping curves (i.e. do not copy the first and last knots in the exported vector). The PR also adds a simple implementation for thewidths
attribute as lifted from the AL plugin's NURBS curve export translator in favour of just authoring a constantwidths
vector of[1]
.