Fixed NURBS curve extents calculation to include widths #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @seando-adsk are we able to get feedback on this current set of changes some time today (#2325, #2326, and #2324)? I apologise for the late notice; these are extenuating circumstances. |
|
@J-Mo63 I had a look the three of them. I'm not too concerned about the last two as they are changes in the AL plugin only. I've asked the team (internally) to look at the first one. I'll try to get back to you asap. |
|
Thanks @seando-adsk, appreciate it greatly! |
pierrebai-adsk
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to continue the alignment between the AL and ADSK plugins' export functionality, updating the AL plugin's NURBS curve export to perform the proper calculations on curve extents (authored as
float3[] extent) by factoring in curve widths using theUsdGeomCurvesimplementation ofComputeExtentin lieu ofUsdGeomPointBased(as it is in the ADSK plugin).