Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial test for shot based animation workflow with custom code-less schema #1997

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

kxl-adsk
Copy link

No description provided.

@kxl-adsk kxl-adsk added the unit test Related to unit tests (both python or c++) label Jan 19, 2022
@kxl-adsk kxl-adsk requested review from boudrey and ppt-adsk January 19, 2022 17:54
@kxl-adsk
Copy link
Author

This is really a test to validate that we can write a complete shot-based animation workflow on top of a custom codeless schema. All python bindings worked out great!

@kxl-adsk
Copy link
Author

I noticed some dead code in the test. Will remove it together with other feedback.

ppt-adsk
ppt-adsk previously approved these changes Jan 19, 2022
Copy link
Collaborator

@ppt-adsk ppt-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a clean demonstration for customers of how they can customize our workflow.

boudrey
boudrey previously approved these changes Jan 19, 2022
@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Jan 20, 2022
@kxl-adsk kxl-adsk merged commit 14f23b9 into dev Jan 20, 2022
@kxl-adsk kxl-adsk deleted the kxl-adsk/custom_rig_schema_reader_and_writer_test branch January 20, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants