Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-120860 Fix TestALUSDMayaPython_LayerManager random fails #1945

Merged
merged 2 commits into from
Jan 5, 2022
Merged

MAYA-120860 Fix TestALUSDMayaPython_LayerManager random fails #1945

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d44ddb
MAYA-120860 Fix TestALUSDMayaPython_LayerManager random fails
boudrey Jan 4, 2022
91c28a3
Cleaner fix.
boudrey Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cmake/test.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,15 @@ finally:
"MAYA_DISABLE_CIP=1"
"MAYA_DISABLE_CER=1")

# Set a temporary folder path for the test
# Note: replace bad chars in test_name with _.
string(REGEX REPLACE "[:<>\|]" "_" SANITIZED_TEST_NAME ${test_name})
set(TEST_TEMP_DIR "${CMAKE_BINARY_DIR}/test/Temporary/${SANITIZED_TEST_NAME}")
set_property(TEST "${test_name}" APPEND PROPERTY ENVIRONMENT
"TMP=${TEST_TEMP_DIR}"
"TEMP=${TEST_TEMP_DIR}")
file(MAKE_DIRECTORY ${TEST_TEMP_DIR})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest just adding these two lines (with your comment) to the env var above on line 340.

        "TMP=${MAYA_APP_TEMP_DIR}"
        "TEMP=${MAYA_APP_TEMP_DIR}")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will, nice catch.


if(IS_MACOSX)
# Necessary for tests like DiffCore to find python
set_property(TEST "${test_name}" APPEND PROPERTY ENVIRONMENT
Expand Down