MAYA-120860 Fix TestALUSDMayaPython_LayerManager random fails #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set TEMP and TMP environment variables for each tests registered with mayaUsd_add_test.
seando-adsk
reviewed
Jan 4, 2022
cmake/test.cmake
Outdated
Comment on lines
359
to
366
| # Set a temporary folder path for the test | ||
| # Note: replace bad chars in test_name with _. | ||
| string(REGEX REPLACE "[:<>\|]" "_" SANITIZED_TEST_NAME ${test_name}) | ||
| set(TEST_TEMP_DIR "${CMAKE_BINARY_DIR}/test/Temporary/${SANITIZED_TEST_NAME}") | ||
| set_property(TEST "${test_name}" APPEND PROPERTY ENVIRONMENT | ||
| "TMP=${TEST_TEMP_DIR}" | ||
| "TEMP=${TEST_TEMP_DIR}") | ||
| file(MAKE_DIRECTORY ${TEST_TEMP_DIR}) |
There was a problem hiding this comment.
I would suggest just adding these two lines (with your comment) to the env var above on line 340.
"TMP=${MAYA_APP_TEMP_DIR}"
"TEMP=${MAYA_APP_TEMP_DIR}")
seando-adsk
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set TEMP and TMP environment variables for each tests registered with mayaUsd_add_test.