-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
audiusd in audius-compose #10859
audiusd in audius-compose #10859
Conversation
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11648675 | Triggered | Generic High Entropy Secret | 43ce675 | pkg/mediorum/mediorum.go | View secret |
11648676 | Triggered | Generic High Entropy Secret | 43ce675 | cmd/core/infra/dev_config/discovery-one.docker.env | View secret |
11648678 | Triggered | Generic High Entropy Secret | b588087 | cmd/core/infra/dev_config/content-three.docker.env | View secret |
11648679 | Triggered | Generic High Entropy Secret | 43ce675 | pkg/mediorum/mediorum.go | View secret |
11648680 | Triggered | Generic High Entropy Secret | b588087 | cmd/core/infra/dev_config/content-one.docker.env | View secret |
11648681 | Triggered | Generic High Entropy Secret | 43ce675 | pkg/mediorum/mediorum.go | View secret |
9412812 | Triggered | Generic Password | 35e2ba4 | dev-tools/compose/docker-compose.blockchain.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@@ -245,3 +245,33 @@ release-aa-backfill: | |||
@DOCKER_DEFAULT_PLATFORM=linux/amd64 docker build -t audius/audio-analysis-backfill:latest -f ./cmd/audio-analysis-backfill/Dockerfile . | |||
@docker push audius/audio-analysis-backfill:latest | |||
|
|||
.PHONY: static-deps | |||
static-deps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment as to why this is needed i.e. why buildx does not work here
[9318508] Upgrade audiusd to bookworm, move off essentia (#10867) endline [937a873] SLA rollup improvements, fixes (#10868) Danny [a38e4b6] Fix search for old clients (#10869) Raymond Jacobson [b555bc5] add dev to healthz (#10862) alecsavvy [373ce1d] add custom legacy profile to core and mediorum (#10866) alecsavvy [c0b91c5] fix ci: add back mediorum and core in legacy docker compose files (#10864) alecsavvy [8ef27ef] Remove go pkg/infra (#10863) endline [04efb42] audiusd in audius-compose (#10859) alecsavvy
Description
Meat and potatoes:
core-$node_type-*
to beaudiusd-*
.audiusd-*
hostnames by default.Side dishes:
make static-deps
which build dependencies that don't need to be built all the time, poa and eth ganache. We can add more to this command later.eth-ganache
andpoa-ganache
to be pulled from dockerhub instead of being built.Dockerfile.cpp
toDockerfile.deps
because vscode was thinking this was an actual C++ file and failing the gls because it thought it required certain build flags.RUN go mod graph | awk '{if ($1 !~ "@") print $2}' | xargs go get
togo mod download
which will cache correctly or bust if go.mod || go.sum change. Previously this would bust the docker cache early.Dockerfile.dev
discovery image to use a python slim base, this significantly speeds up build times. In particular all the wheels. See here for more details. We should move the prod image over as well but didn't want to touch that here.Dockerfile.dev
for discovery so if the pulled file matches the previous one docker will consider it cached and move on. This was busting the cache early before the pip requirements installation so that explains why wheels were being built all the time.register.py
that runs when discovery starts up. This has been failing for a long time and is replaced by core registering itself on dev.dev-tools/setup.py
which dynamically set some env vars for dev discovery. There's some further improvements we can make here.noop
s openresty in dev, sets it to a busybox container (~1mb) that doesn't even get included duringaudius-compose up
. We do need the entry in there for the root discovery compose file to extend from.How Has This Been Tested?
audius-compose build
saudius-compose up