Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As/infra dev cleanup #10844

Closed
wants to merge 12 commits into from
Closed

As/infra dev cleanup #10844

wants to merge 12 commits into from

Conversation

alecsavvy
Copy link
Contributor

Description

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: f28926d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Dec 26, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648675 Triggered Generic High Entropy Secret 43ce675 pkg/mediorum/mediorum.go View secret
11648676 Triggered Generic High Entropy Secret 43ce675 cmd/core/infra/dev_config/discovery-one.docker.env View secret
11648678 Triggered Generic High Entropy Secret b588087 cmd/core/infra/dev_config/content-three.docker.env View secret
11648679 Triggered Generic High Entropy Secret 43ce675 pkg/mediorum/mediorum.go View secret
11648680 Triggered Generic High Entropy Secret b588087 cmd/core/infra/dev_config/content-one.docker.env View secret
11648681 Triggered Generic High Entropy Secret 43ce675 pkg/mediorum/mediorum.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@alecsavvy
Copy link
Contributor Author

closing in favor of #10859

@alecsavvy alecsavvy closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant