Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

[C-2681, C-2682, C-2683] Add new upload finish page #3890

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[C-2681, C-2682, C-2683] Add new upload finish page #3890

merged 1 commit into from
Aug 16, 2023

Conversation

Kyle-Shanks
Copy link
Contributor

Description

Adding the new components for the upload finish page and update the new upload flow to upload the tracks and display the finish page

[Going to add a vid soon]

Dragons

N/A

How Has This Been Tested?

Lots of manual testing, lots more to come in the future

How will this change be monitored?

N/A

Feature Flags

N/A

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/kj-Add-new-finish-upload-page

@Kyle-Shanks Kyle-Shanks force-pushed the kj-Add-new-finish-upload-page branch from c6e08d2 to 969b58f Compare August 16, 2023 18:29
dylanjeffers
dylanjeffers approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking sweet! just some comments about the onContinue, like what state we actually need to keep track of to know where we are at, comment around twitter button, and the progress selector

packages/web/src/pages/upload-page/components/FinishPageNew.tsx
return <LoadingSpinner className={styles.progressIndicator} />
case ProgressStatus.COMPLETE:
case ProgressStatus.PROCESSING:
return <IconValidationCheck className={styles.progressIndicator} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clutch so was this the reusable icon check component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, its a slightly different green though

packages/web/src/pages/upload-page/UploadPageNew.tsx
}

const handleUpload = useCallback(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it makes sense for this to be a part of the finish page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it could be fine in either place. put it here bc thats how it existed in the legacy upload flow

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/kj-Add-new-finish-upload-page

@Kyle-Shanks Kyle-Shanks force-pushed the kj-Add-new-finish-upload-page branch from 969b58f to 6b3b89b Compare August 16, 2023 20:34
@Kyle-Shanks Kyle-Shanks merged commit b73b2f6 into main Aug 16, 2023
@Kyle-Shanks Kyle-Shanks deleted the kj-Add-new-finish-upload-page branch August 16, 2023 20:44
schottra added a commit that referenced this pull request Aug 17, 2023
@schottra
Merge remote-tracking branch 'origin/main' into pay-1631-post-purchas…
e88bc55 
…e-page

* origin/main:
  [PAY-1720] Implements PlainButton (#3897)
  Fix minor bugs for multi-track upload demo (#3854)
  Limit lines in Leaving Audius Modal (#3896)
  [C-2681, C-2682, C-2683] Add new upload finish page (#3890)
  [C-2914] USDC purchase options for new upload UI (web) (#3888)
  Minor UI fixes for leaving audius modal (#3895)
  Fix OAuth login page width (#3894)
  Fix playlist form from crashing after double save (#3893)
  Update seo h1 to be accessibly hidden vs visually hidden (#3892)
  Move setCollectionPermalink within fetchCollectionSucceeded action (#3867)
  [plat-1055] revert legacy playlist route formatting in embed player to use permalink (#3824)
  [PAY-1717] Make sign in/sign up page overlap banner (#3886)
  [PAY-1658] Artist pick, hidden track tile tags moved to mid-left (#3889)
  [C-2957] Add h1 tag for SEO (#3887)
  [C-2685 C-2686] Implement collection upload form (#3870)
  [PAY-1702] Use existing chats as default user list when sharing to DMs (#3877)
  [PAY-1701] Fix "Share to DMs" on mobile to go through InboxUnavailable modal (#3878)
  [PAY-1700] Replace navigation if coming from ChatUserListScreen (#3879)
  [PAY-1588] Use existing balance in purchase flow on mobile (#3885)
audius-infra pushed a commit that referenced this pull request Aug 19, 2023
v1.5.38
e953bb8 
[bd3fdc7] [C-2972] Fix feed, trending track-page seo (#3907) Dylan Jeffers
[45279fe] [C-2969] Fix related artist images not loading (#3905) Andrew Mendelsohn
[f51e6ac] [C-2961] Fix LeftNav SEO (#3906) Dylan Jeffers
[6256792] Fix lint in useUserProfilePicture (#3903) Dylan Jeffers
[f7dc55b] [C-2971] Add Avatar (#3902) Dylan Jeffers
[ce441c1] [C-2970] Add Link, Improve Text (#3901) Dylan Jeffers
[72fcc88] [PAY-1631] Implements post-purchase content on web (#3898) Randy Schott
[0f28578] [C-2964] Cannonical URL should be uri encoded (#3899) Raymond Jacobson
[3fca3c9] [C-2684 C-2955] Improve upload component hierarchy, state, and validation (#3891) Dylan Jeffers
[3138da3] [PAY-1720] Implements PlainButton (#3897) Randy Schott
[b353f94] Fix minor bugs for multi-track upload demo (#3854) Andrew Mendelsohn
[22d4be5] Limit lines in Leaving Audius Modal (#3896) Marcus Pasell
[b73b2f6] [C-2681, C-2682, C-2683] Add new upload finish page (#3890) Kyle Shanks
[5d94b1f] [C-2914] USDC purchase options for new upload UI (web) (#3888) Andrew Mendelsohn
[30cc8f1] Minor UI fixes for leaving audius modal (#3895) Marcus Pasell
[970f411] Fix OAuth login page width (#3894) nicoback2
[deff919] Fix playlist form from crashing after double save (#3893) sabrina-kiam
[18227f3] Update seo h1 to be accessibly hidden vs visually hidden (#3892) Dylan Jeffers
[594b5c4] Move setCollectionPermalink within fetchCollectionSucceeded action (#3867) sabrina-kiam
[9165c76] [plat-1055] revert legacy playlist route formatting in embed player to use permalink (#3824) sabrina-kiam
[eb747cf] [PAY-1717] Make sign in/sign up page overlap banner (#3886) Marcus Pasell
[2887342] [PAY-1658] Artist pick, hidden track tile tags moved to mid-left (#3889) Reed
[2c80443] [C-2957] Add h1 tag for SEO (#3887) Raymond Jacobson
[bae86c3] [C-2685 C-2686] Implement collection upload form (#3870) Dylan Jeffers
[1c7ec6f] [PAY-1702] Use existing chats as default user list when sharing to DMs (#3877) Marcus Pasell
[bf09344] [PAY-1701] Fix "Share to DMs" on mobile to go through InboxUnavailable modal (#3878) Marcus Pasell
[9c9d7f4] [PAY-1700] Replace navigation if coming from ChatUserListScreen (#3879) Marcus Pasell
[eaef4e6] [PAY-1588] Use existing balance in purchase flow on mobile (#3885) Reed
[49d1d05] Add fb share page (#3876) Raymond Jacobson
[46c33eb] Change nullish check to falsey check for collection track times (#3884) Kyle Shanks
[b773045] Update twitter icon on mobile (#3880) Reed
[dfc6c60] [PAY-1707] Implements usage of existing balance during content purchases (#3883) Randy Schott
[5b4242f] [PAY-1592] Wire up USDC purchase flow on mobile (#3881) Reed
[41cc4af] [PAY-1629] Purchase flow cleanup (#3873) Randy Schott
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

@amendelsohn amendelsohn Awaiting requested review from amendelsohn

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kyle-Shanks @audius-infra @dylanjeffers