This repository has been archived by the owner on Oct 4, 2023. It is now read-only.
Update twitter icon on mobile #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Shanks
reviewed
Aug 14, 2023
There was a problem hiding this comment.
gross, we should do a pass of our icons at some point to get rid of ones like this
Kyle-Shanks
approved these changes
Aug 14, 2023
audius-infra
pushed a commit
that referenced
this pull request
Aug 19, 2023
[bd3fdc7] [C-2972] Fix feed, trending track-page seo (#3907) Dylan Jeffers [45279fe] [C-2969] Fix related artist images not loading (#3905) Andrew Mendelsohn [f51e6ac] [C-2961] Fix LeftNav SEO (#3906) Dylan Jeffers [6256792] Fix lint in useUserProfilePicture (#3903) Dylan Jeffers [f7dc55b] [C-2971] Add Avatar (#3902) Dylan Jeffers [ce441c1] [C-2970] Add Link, Improve Text (#3901) Dylan Jeffers [72fcc88] [PAY-1631] Implements post-purchase content on web (#3898) Randy Schott [0f28578] [C-2964] Cannonical URL should be uri encoded (#3899) Raymond Jacobson [3fca3c9] [C-2684 C-2955] Improve upload component hierarchy, state, and validation (#3891) Dylan Jeffers [3138da3] [PAY-1720] Implements PlainButton (#3897) Randy Schott [b353f94] Fix minor bugs for multi-track upload demo (#3854) Andrew Mendelsohn [22d4be5] Limit lines in Leaving Audius Modal (#3896) Marcus Pasell [b73b2f6] [C-2681, C-2682, C-2683] Add new upload finish page (#3890) Kyle Shanks [5d94b1f] [C-2914] USDC purchase options for new upload UI (web) (#3888) Andrew Mendelsohn [30cc8f1] Minor UI fixes for leaving audius modal (#3895) Marcus Pasell [970f411] Fix OAuth login page width (#3894) nicoback2 [deff919] Fix playlist form from crashing after double save (#3893) sabrina-kiam [18227f3] Update seo h1 to be accessibly hidden vs visually hidden (#3892) Dylan Jeffers [594b5c4] Move setCollectionPermalink within fetchCollectionSucceeded action (#3867) sabrina-kiam [9165c76] [plat-1055] revert legacy playlist route formatting in embed player to use permalink (#3824) sabrina-kiam [eb747cf] [PAY-1717] Make sign in/sign up page overlap banner (#3886) Marcus Pasell [2887342] [PAY-1658] Artist pick, hidden track tile tags moved to mid-left (#3889) Reed [2c80443] [C-2957] Add h1 tag for SEO (#3887) Raymond Jacobson [bae86c3] [C-2685 C-2686] Implement collection upload form (#3870) Dylan Jeffers [1c7ec6f] [PAY-1702] Use existing chats as default user list when sharing to DMs (#3877) Marcus Pasell [bf09344] [PAY-1701] Fix "Share to DMs" on mobile to go through InboxUnavailable modal (#3878) Marcus Pasell [9c9d7f4] [PAY-1700] Replace navigation if coming from ChatUserListScreen (#3879) Marcus Pasell [eaef4e6] [PAY-1588] Use existing balance in purchase flow on mobile (#3885) Reed [49d1d05] Add fb share page (#3876) Raymond Jacobson [46c33eb] Change nullish check to falsey check for collection track times (#3884) Kyle Shanks [b773045] Update twitter icon on mobile (#3880) Reed [dfc6c60] [PAY-1707] Implements usage of existing balance during content purchases (#3883) Randy Schott [5b4242f] [PAY-1592] Wire up USDC purchase flow on mobile (#3881) Reed [41cc4af] [PAY-1629] Purchase flow cleanup (#3873) Randy Schott
dharit-tan
added a commit
that referenced
this pull request
Aug 22, 2023
This reverts commit b773045.
dharit-tan
added a commit
that referenced
this pull request
Aug 22, 2023
dharit-tan
added a commit
that referenced
this pull request
Aug 22, 2023
schottra
added a commit
that referenced
this pull request
Aug 25, 2023
* origin/main: Add lint check for console.log and remove some bad ones (#3930) [C-2968] Fix private collection action buttons (#3937) Fix canonical url consistency (#3938) [C-2689] Add upload confirmation modal (#3934) [C-2966] Make sure that collection description limits are set to 1000 (#3935) Move sitemap hostname back to audius.co (#3931) Client uses cids in requests to CN for images (#3882) Add library albums and playlists audius-query hook + migrate collection reformat util; bump SDK PAY-1679 (#3864) [C-2982] Fix seo based on ahref recommendations (#3929) Migrate withdraw USDC saga to web common (#3928) USDC Withdrawal saga scaffolding (#3926) Fix useAllPaginated query C-2980 (#3924) Fix infinite scrolling cards C-2979 (#3923) [PAY-1632] Clean up and improve performance of music confetti (#3921) Revert "Update twitter icon on mobile (#3880)" (#3925)
audius-infra
pushed a commit
that referenced
this pull request
Aug 26, 2023
[b39cb5d] [PAY-1733] Remove Gated Prompt Modal (#3948) Marcus Pasell [a522294] [PAY-1748][PAY-1731][PAY-1729][PAY-1730] DMs link fixes (#3946) Marcus Pasell [adea357] quick linting fix (#3945) Kyle Shanks [a0ff27c] Add embed cloudflare deployment and CI (#3940) Raymond Jacobson [337f80f] [PAY-1727] USDC Withdrawals saga pt. 1 (#3932) Reed [5bf820c] [C-2956] Add new Access & Sale modal to legacy upload form (#3900) Andrew Mendelsohn [5258675] [C-2986] Upload flow qa round 1 (#3941) Kyle Shanks [dd30c09] Use does_current_user_subscribe API field (#3943) Michelle Brier [778a518] [C-2987] Add UserGeneratedText (#3942) Dylan Jeffers [bb9e0cf] Update pull_request_template.md (#3939) Raymond Jacobson [930dd1a] [C-2977] Fix collection page seo (#3936) Dylan Jeffers [1e50b85] Update README.md (#3911) sabrina-kiam [687fd28] Add lint check for console.log and remove some bad ones (#3930) Raymond Jacobson [9f67e7b] [C-2968] Fix private collection action buttons (#3937) Dylan Jeffers [7ab7a38] Fix canonical url consistency (#3938) Dylan Jeffers [b1fbef8] [C-2689] Add upload confirmation modal (#3934) Kyle Shanks [eb41fd3] [C-2966] Make sure that collection description limits are set to 1000 (#3935) Kyle Shanks [6258484] Move sitemap hostname back to audius.co (#3931) Raymond Jacobson [1e0c335] Client uses cids in requests to CN for images (#3882) Michelle Brier [7974acc] Add library albums and playlists audius-query hook + migrate collection reformat util; bump SDK PAY-1679 (#3864) nicoback2 [7cba35b] [C-2982] Fix seo based on ahref recommendations (#3929) Dylan Jeffers [05744b3] Migrate withdraw USDC saga to web common (#3928) Reed [5d01710] USDC Withdrawal saga scaffolding (#3926) Reed [4e0c480] Fix useAllPaginated query C-2980 (#3924) nicoback2 [21eb35c] Fix infinite scrolling cards C-2979 (#3923) nicoback2 [0025261] [PAY-1632] Clean up and improve performance of music confetti (#3921) Raymond Jacobson [7ed2248] Revert "Update twitter icon on mobile (#3880)" (#3925) Reed [1091934] [PAY-1742] Remove useMetaMask on invalid account (#3920) Raymond Jacobson [6e303b1] [PAY-1741] Add routes for transactional pages (#3916) Randy Schott [74cdb3c] Remove ontouchstart from index.html (#3919) Raymond Jacobson [1a0332c] Improve lighthouse score (#3918) Raymond Jacobson [a63896f] [PAY-1706] Merge modalsWithState with modals in common store (#3908) Marcus Pasell [6a08944] [C-2976] Fix profile-page seo (#3912) Dylan Jeffers [2381d46] Fix account details css (#3917) Raymond Jacobson [8c24bdd] Fix mobile share of playlist permalink (#3913) sabrina-kiam [1e376fe] [C-2911] Update new select page of the upload flow (#3910) Kyle Shanks [bc0226f] Fix stripe modal opening behavior (#3914) Raymond Jacobson [a3219c3] [C-2975] Fix stale local data (#3915) Dylan Jeffers [748fdfd] PAY-1724 Add color specialGreen on mobile (#3909) Reed [5c59fe5] [PAY-1628] Navigate to track after purchase (#3904) Randy Schott
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use new twitter icon, update sizes to match new designs.
Just did this bc noticed the designs were slightly different while working on usdc stuff.
Dragons
Probably want to QA this w/ Julian before release but I will handle.
How Has This Been Tested?
Local ios stage
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.