-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js/openinference-core): Port build process to vite, advertise esm builds #1150
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
export * from "./contextAttributes"; | ||
export * from "./types"; | ||
export type * from "./types"; | ||
export * from "./trace-config"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
import path, { resolve } from "path"; | ||
import { defineConfig } from "vite"; | ||
import { globSync } from "glob"; | ||
import { fileURLToPath } from "url"; | ||
|
||
export default defineConfig({ | ||
build: { | ||
lib: { | ||
// Map every source file as an entry point so that they are not bundled, each file becomes its | ||
// own chunk essentially. | ||
// see https://rollupjs.org/configuration-options/#input | ||
entry: Object.fromEntries( | ||
globSync("src/**/*.ts").map((file) => [ | ||
// This remove `src/` as well as the file extension from each | ||
// file, so e.g. src/nested/foo.js becomes nested/foo | ||
path.relative( | ||
"src", | ||
file.slice(0, file.length - path.extname(file).length), | ||
), | ||
// This expands the relative paths to absolute paths, so e.g. | ||
// src/nested/foo becomes /project/src/nested/foo.js | ||
fileURLToPath(new URL(file, import.meta.url)), | ||
]), | ||
), | ||
formats: ["es", "cjs"], | ||
}, | ||
minify: false, | ||
rollupOptions: { | ||
output: [ | ||
{ | ||
format: "es", | ||
dir: resolve(__dirname, "dist", "esm"), | ||
}, | ||
{ | ||
format: "esm", | ||
dir: resolve(__dirname, "dist", "esnext"), | ||
entryFileNames: "[name].js", | ||
}, | ||
{ | ||
format: "cjs", | ||
dir: resolve(__dirname, "dist", "src"), | ||
}, | ||
], | ||
// make sure to externalize deps that shouldn't be bundled | ||
// into your library | ||
external: ["@opentelemetry/api", "@opentelemetry/core"], | ||
}, | ||
}, | ||
}); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, can this be done via peerDeps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not automatically, no. From what I understand the best we could do is to import package.json and walk the peerDependencies deps, adding them to this config.
vitejs/vite#6780