feat(js/openinference-core): Port build process to vite, advertise esm builds #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeldking
reviewed
Dec 5, 2024
Comment on lines
+44
to
+46
| // make sure to externalize deps that shouldn't be bundled | ||
| // into your library | ||
| external: ["@opentelemetry/api", "@opentelemetry/core"], |
There was a problem hiding this comment.
ugh, can this be done via peerDeps?
There was a problem hiding this comment.
Not automatically, no. From what I understand the best we could do is to import package.json and walk the peerDependencies deps, adding them to this config.
|
This isn't the right approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build processes converted to vite/rollup to facilitate extension/import rewriting:
New distributables tested: