-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Param: add @SYS/defaults.parm
and log default values
#20972
Conversation
Look like this is just enough to push Hitec Airspeed over the edge, its only getting the AP_Param changes, could aggressively define them out on periph I guess.... |
b730d32
to
e358675
Compare
Functionality now removed on Periph as much as possible to minimize flash cost. Also tested with params loaded from scripting, works as expected. |
5eedb8c
to
a4b79ad
Compare
a4b79ad
to
4e84b59
Compare
Compare to tridge@065159b |
4e84b59
to
89e5b69
Compare
Added support for packed defaults via the param ftp format. This still has The is some additional work to make sure the defaults are set correctly. We need to check everywhere using the param |
89e5b69
to
0d86d36
Compare
Just tested with ArduPilot/MAVProxy#1077 seems to work as expected. mav.parm.defaults.txt I set also set the first three servo trims in |
6570e3b
to
a6db42b
Compare
@tridge I have implemented, I think, the protocol you suggested. |
a6db42b
to
e051423
Compare
e051423
to
116a157
Compare
rebased to resolve conflict |
great work! |
This adds a
@SYS/defaults.parm
ftp file that contains all the defaults for the board. Those default values are also logged in thePARM
log at first arming. You do not get the defaults again with run-time changes.This works, however we need to make sure everywhere is calling
set_default
not justset
, this induces changes toAC_PID
to follow that pattern so the defaults are correctly recorded. There are probably other places that doing the wrong thing where we would not get the correct value.This does keep a linked list of all the params that have ever had
set_defualt
called on them, so we should probably not do that too much.... I have not calculated how many this is, probably less than 50...The goal of this is to make it very easy to spot which params have been changed, with this patch one can grab the defaults over ftp and do a param compare.