Grab param defaults and display in full list #2907
Conversation
ExtLibs/ArduPilot/parampck.cs
Outdated
| case 'i': return BitConverter.ToUInt32(data, startIndex); | ||
| case 'f': return BitConverter.ToSingle(data, startIndex); | ||
| case 'b': return (sbyte)data[startIndex]; | ||
| case 'h': return (short)BitConverter.ToUInt16(data, startIndex); |
There was a problem hiding this comment.
I was getting -1 warping to int max. This matches the return types from here:
MissionPlanner/ExtLibs/Mavlink/MAVLinkParam.cs
Lines 48 to 55 in 43712f7
There was a problem hiding this comment.
should we be casting? or reading in the correct format? ie ToUint16 vs ToInt16 ?
There was a problem hiding this comment.
Your right, it looks like I just have the wrong conversion. Copy and paste fail on my part.
There was a problem hiding this comment.
Changed to use correct types.
ExtLibs/ArduPilot/parampck.cs
Outdated
| @@ -97,6 +100,16 @@ public static MAVLink.MAVLinkParamList unpack(byte[] data) | |||
| Array.Copy(data, dataPointer, vdata, 0, mapped.type_len); | |||
| dataPointer += mapped.type_len; | |||
|
|
|||
| double default_value = Double.NaN; | |||
There was a problem hiding this comment.
can we change this to "decimal" from double. the reason being a recent rounding issue, and decimal internally deals with this better.
There was a problem hiding this comment.
changed to a nullable decimal decimal?
|
AP support for this just got merged, I have also just retested with stable AP 4.2 and it still works with this change. |
|
final confirmation. you happy with this now? |
|
@meee1 yep, I think so. Thanks. |
Implementation of updated ftp format per ArduPilot/ardupilot#20972
Displays all defualt values and adds tick box to only show params which have a none default value.
This is the full list only, still works with older version new stuff is hidden in that case.
Would be nice to make the save to file have a option to only save none defualts too.
Only draft because needs the AP pr merged first.