Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Add unittest verifying that proposer policy does not become active when finality has stalled (and a couple other) #607

Merged
merged 9 commits into from
Aug 22, 2024
+294 −5
Merged

[1.0] Add unittest verifying that proposer policy does not become active when finality has stalled (and a couple other) #607

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3211b33
Add proposer policy tests for Savanna.
greg7mdp Aug 20, 2024
6b72ce0
Merge branch 'release/1.0' of github.com:AntelopeIO/spring into gh_553
greg7mdp Aug 20, 2024
b05c72e
Add check validating that the proposer policy is pending after produc…
greg7mdp Aug 20, 2024
2606f4a
Address PR comments - part 1
greg7mdp Aug 21, 2024
310264c
Add `no_proposer_policy_change_without_finality_2` test
greg7mdp Aug 21, 2024
677eb03
Update `pending_proposer_policy_becomes_active_without_finality` test.
greg7mdp Aug 21, 2024
1e7dd28
Minor changes (add a check)
greg7mdp Aug 21, 2024
95620bf
Address some PR comments.
greg7mdp Aug 21, 2024
e1c7d29
Address PR comment by adjusting while condition so that the comment i…
greg7mdp Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions unittests/savanna_proposer_policy_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ BOOST_FIXTURE_TEST_CASE(policy_change_first_block_delay_check, savanna_cluster::
// ---------------------------------------------------------------------------------------------------
BOOST_FIXTURE_TEST_CASE(policy_change_sixth_block_delay_check, savanna_cluster::cluster_t) try {
auto& A=_nodes[0];
uint32_t middle = prod_rep / 2;
assert(middle > 0);
const uint32_t middle = prod_rep / 2;
static_assert(middle > 0);

while(A.head().timestamp().slot % prod_rep != middle - 1)
A.produce_block();
Expand Down Expand Up @@ -91,8 +91,8 @@ BOOST_FIXTURE_TEST_CASE(policy_change_sixth_block_delay_check, savanna_cluster::
// ---------------------------------------------------------------------------------------------------
BOOST_FIXTURE_TEST_CASE(policy_change_last_block_delay_check, savanna_cluster::cluster_t) try {
auto& A=_nodes[0];
uint32_t last = prod_rep - 1;
assert(last > 0);
const uint32_t last = prod_rep - 1;
static_assert(last > 0);

while(A.head().timestamp().slot % prod_rep != last - 1)
A.produce_block();
Expand Down Expand Up @@ -234,6 +234,7 @@ BOOST_FIXTURE_TEST_CASE(no_proposer_policy_change_without_finality_2, savanna_cl
// ---------------------------------------------------------------------------------------------------
BOOST_FIXTURE_TEST_CASE(pending_proposer_policy_becomes_active_without_finality, savanna_cluster::cluster_t) try {
auto& A=_nodes[0];
static_assert(prod_rep >= 4);
arhag marked this conversation as resolved.
Show resolved Hide resolved

auto sb = A.produce_block();
auto orig_producer = sb->producer;
Expand All @@ -247,7 +248,7 @@ BOOST_FIXTURE_TEST_CASE(pending_proposer_policy_becomes_active_without_finality,
A.create_accounts(producers);
A.tester::set_producers(producers); // push the action to update the producer schedule
A.produce_block(); // produce a block that will include the policy change transaction
A.produce_blocks(12); // produce 12 blocks which guarantees that the proposer policy is pending
A.produce_blocks(prod_rep); // produce `prod_rep` blocks which guarantees that the proposer policy is pending

// split network { A, B } and { C, D }
// Regardless of how many blocks A produces, finality will not advance
Expand All @@ -266,7 +267,9 @@ BOOST_FIXTURE_TEST_CASE(pending_proposer_policy_becomes_active_without_finality,

// produce `prod_rep` more blocks. Finality will not be advancing anymore, but still the new policy
// will become active because it was already pending.
arhag marked this conversation as resolved.
Show resolved Hide resolved
// -----------------------------------------------------------------------------------------------------
// Indeed, the new policy would eventually become active as long as it was simply *proposed* prior to the
// last final block when finality stalled, but this is not verified in this test.
// ------------------------------------------------------------------------------------------------------
sb = A.produce_blocks(prod_rep);
BOOST_REQUIRE_EQUAL(A.lib_number, orig_lib_num); // check lib didn't advance
BOOST_REQUIRE_GT(A.control->active_producers().version, orig_version);// check producer schedule version is greater
Expand Down