Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Add unittest verifying that proposer policy does not become active when finality has stalled (and a couple other) #607

Merged
merged 9 commits into from
Aug 22, 2024
Merged

[1.0] Add unittest verifying that proposer policy does not become active when finality has stalled (and a couple other) #607

merged 9 commits into from
Aug 22, 2024

Conversation

greg7mdp
Copy link
Contributor

Resolves #553.

Also added tests verifying that:

  1. when finality advances, proposer policy transitions happens on the expected block.
  2. if a proposer policy is already pending, it will become active even if finality stalls.

@greg7mdp greg7mdp requested review from heifner and arhag August 20, 2024 21:57
@arhag arhag changed the title Add untitest verifying that proposer policy does not become active when finality has stalled (and a couple other) [1.0] Add untitest verifying that proposer policy does not become active when finality has stalled (and a couple other) Aug 20, 2024
@arhag arhag linked an issue Aug 20, 2024 that may be closed by this pull request
Test proposer policy does not become active when finality has stalled #553
Closed
arhag
arhag requested changes Aug 20, 2024
View reviewed changes
unittests/savanna_proposer_policy_tests.cpp Show resolved Hide resolved
unittests/savanna_proposer_policy_tests.cpp Show resolved Hide resolved
unittests/savanna_proposer_policy_tests.cpp Outdated Show resolved Hide resolved
@greg7mdp greg7mdp changed the title [1.0] Add untitest verifying that proposer policy does not become active when finality has stalled (and a couple other) [1.0] Add unittest verifying that proposer policy does not become active when finality has stalled (and a couple other) Aug 21, 2024
arhag
arhag approved these changes Aug 21, 2024
View reviewed changes
unittests/savanna_proposer_policy_tests.cpp Show resolved Hide resolved
unittests/savanna_proposer_policy_tests.cpp Outdated Show resolved Hide resolved
unittests/savanna_proposer_policy_tests.cpp Show resolved Hide resolved
@greg7mdp greg7mdp requested review from heifner and removed request for heifner August 21, 2024 22:18
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: TEST
summary: Add test to validate proposed finality policy does not become active when chain finality is not progressing.
Note:end

heifner
heifner approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clean!

@greg7mdp greg7mdp merged commit 68de44f into release/1.0 Aug 22, 2024
36 checks passed
@greg7mdp greg7mdp deleted the gh_553 branch August 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test proposer policy does not become active when finality has stalled
4 participants
@greg7mdp @ericpassmore @heifner @arhag