Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta3 -> main] P2P: Set peer_syncing_from_us to false when a recent block is received #318

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 22, 2024

A node will set peer_syncing_from_us to false on a request_message of none or if it receives a handshake indicating it is synced. This PR sets peer_syncing_from_us to false if a node receive a recent block from the network as blocks are only relayed after they are validated. Therefore, if we receive a recent block from a peer we know that peer can't be syncing from us even if they have failed to send us a handshake letting us know they are up to date.

Merges release/1.0-beta3 into main including #315 & #317

Resolves #302

@heifner heifner requested review from greg7mdp and linh2931 June 22, 2024 13:46
@heifner heifner added the OCI Work exclusive to OCI team label Jun 22, 2024
@heifner heifner linked an issue Jun 22, 2024 that may be closed by this pull request
Base automatically changed from avoid_unrotate_+_rewrite_tests to main June 27, 2024 12:00
plugins/net_plugin/net_plugin.cpp Show resolved Hide resolved
@heifner heifner merged commit 315c01a into main Jun 27, 2024
36 checks passed
@heifner heifner deleted the GH-302-sync-main branch June 27, 2024 12:55
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Add cases where we update peer syncing status to more accurately reflect peer syncing from us status.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: lib_advance_if_test
4 participants