[1.0-beta2] P2P: Set peer_syncing_from_us to false when a recent block is received #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
reviewed
Jun 18, 2024
| if( app().is_quiting() ) { | ||
| c->close( false, true ); | ||
| return; | ||
| } | ||
| c->latest_blk_time = std::chrono::system_clock::now(); | ||
| c->block_status_monitor_.accepted(); | ||
| if (blk_latency.count() < config::block_interval_us && c->peer_syncing_from_us) { |
There was a problem hiding this comment.
You probably don't need && c->peer_syncing_from_us.
linh2931
approved these changes
Jun 18, 2024
greg7mdp
approved these changes
Jun 19, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A node will set
peer_syncing_from_ustofalseon arequest_messageofnoneor if it receives a handshake indicating it is synced. This PR setspeer_syncing_from_ustofalseif a node receive a recent block from the network as blocks are only relayed after they are validated. Therefore, if we receive a recent block from a peer we know that peer can't be syncing from us even if they have failed to send us a handshake letting us know they are up to date.Resolves #302