[4.0 -> main] Increase robustness of snapshot diff python test #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.0] Test Fix: Pass a large time limit to get table call
…ness [4.0] Increase robustness of snapshot diff python test
tests/TestHarness/queries.py
Outdated
| @@ -346,7 +346,7 @@ def getEosAccount(self, name, exitOnError=False, returnType=ReturnType.json): | |||
| return self.processCleosCmd(cmd, cmdDesc, silentErrors=False, exitOnError=exitOnError, exitMsg=msg, returnType=returnType) | |||
|
|
|||
| def getTable(self, contract, scope, table, exitOnError=False): | |||
| cmdDesc = "get table" | |||
| cmdDesc = "get table --time-limit 999" | |||
There was a problem hiding this comment.
This will probably break nodeos 2.0 compatibility for performance test. This time limit is handled in configureVersion(self) as self.cleosLimit but was lost due to the splitting of Node.py into queries.
https://github.com/AntelopeIO/leap/pull/874/files#diff-4d1412150dda54fbc6280cc9053914a45d01e43085e35b0a5a68e9c8758ed42bR350 restores this in a way that won't break 2.0 compatibility.
There was a problem hiding this comment.
I see, that was brought from un-merged to main PR with Kevin's commit, should I just remove this change from this PR? It has nothing to do with said python test
There was a problem hiding this comment.
removed it from this pr, so it properly has only one file with my changes
heifner
approved these changes
Mar 23, 2023
linh2931
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing in #856 to main
This PR mitigates rare and annoying issue of the test failing when there is a new block happening in between of scheduling and "now" create_snapshot calls. The fix is to execute create_snapshot first and schedule programmable snapshot at exact same block num. Same as with irreversible one.
Resolves #853