[4.0 -> main] Test Fix: Pass a large time limit to get table call #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[4.0] Test Fix: Pass a large time limit to get table call
greg7mdp
approved these changes
Mar 22, 2023
vladtr
approved these changes
Mar 22, 2023
| @@ -346,7 +346,7 @@ def getEosAccount(self, name, exitOnError=False, returnType=ReturnType.json): | |||
| return self.processCleosCmd(cmd, cmdDesc, silentErrors=False, exitOnError=exitOnError, exitMsg=msg, returnType=returnType) | |||
|
|
|||
| def getTable(self, contract, scope, table, exitOnError=False): | |||
| cmdDesc = "get table" | |||
| cmdDesc = "get table --time-limit 999" | |||
There was a problem hiding this comment.
This will probably break nodeos 2.0 compatibility for performance test. This time limit is handled in configureVersion(self) as self.cleosLimit but was lost due to the splitting of Node.py into queries.
https://github.com/AntelopeIO/leap/pull/874/files#diff-4d1412150dda54fbc6280cc9053914a45d01e43085e35b0a5a68e9c8758ed42bR350 restores this in a way that won't break 2.0 compatibility.
There was a problem hiding this comment.
Thanks @ClaytonCalabrese !
|
Closing as this is fixed by #875 and fixed up in main via #880. Thanks @ClaytonCalabrese & @766C6164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify integration tests to pass a large time-limit to get table calls so it does not have to handle the timeout
more=trueif the default 10ms is not enough time.Merges #852 into
main.Resolves #850