Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0 -> main] Test Fix: Pass a large time limit to get table call #865

Closed
wants to merge 3 commits into from
Closed

[4.0 -> main] Test Fix: Pass a large time limit to get table call #865

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
446a04a
GH-850 Pass a large time limit so python does not have to handle more…
heifner Mar 21, 2023
87c7480
Merge pull request #852 from AntelopeIO/GH-850-test-fix
heifner Mar 22, 2023
d596dd0
Merge remote-tracking branch 'origin/release/4.0' into GH-850-test-fi…
heifner Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/TestHarness/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def getEosAccount(self, name, exitOnError=False, returnType=ReturnType.json):
return self.processCleosCmd(cmd, cmdDesc, silentErrors=False, exitOnError=exitOnError, exitMsg=msg, returnType=returnType)

def getTable(self, contract, scope, table, exitOnError=False):
cmdDesc = "get table"
cmdDesc = "get table --time-limit 999"
Copy link
Contributor

@ClaytonCalabrese ClaytonCalabrese Mar 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably break nodeos 2.0 compatibility for performance test. This time limit is handled in configureVersion(self) as self.cleosLimit but was lost due to the splitting of Node.py into queries.

https://github.com/AntelopeIO/leap/pull/874/files#diff-4d1412150dda54fbc6280cc9053914a45d01e43085e35b0a5a68e9c8758ed42bR350 restores this in a way that won't break 2.0 compatibility.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ClaytonCalabrese !

cmd="%s %s %s %s" % (cmdDesc, contract, scope, table)
msg="contract=%s, scope=%s, table=%s" % (contract, scope, table);
return self.processCleosCmd(cmd, cmdDesc, exitOnError=exitOnError, exitMsg=msg)
Expand Down