Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned Build Script Changes #811

Closed
wants to merge 23 commits into from
Closed

Pinned Build Script Changes #811

wants to merge 23 commits into from

Conversation

kj4ezj
Copy link
Contributor

@kj4ezj kj4ezj commented Mar 13, 2023

From issue 735, this pull request fixes the pinned build by returning the libcurl4-openssl-dev dependency.

It also contains changes to the script output with the intention of making it easier to debug and easier to understand where in the process the script is. Mostly this means adding echo statements but, notably, I also switched from wget to curl because wget was throwing up in my terminal and curl gives us more control anyways. It is possible wget can be removed from the list of dependencies, but I did not remove it because I was not certain it was unused (for example, in the CMake).

See Also

  1. Pull Request 833 - Fix Pinned Build on Ubuntu 22.04
  2. Pull Request 812 - Pinned Build Script Linter Changes
  3. Pull Request 835 - Change ASCII Art Banner in Build Script
  4. Pull Request 832 - Roll install_deps.sh into pinned_build.sh
  5. Pull Request 847 - Restore libcurl4-openssl-dev
  6. Pull Request 849 - Fix README.md Formatting
  7. Pull Request 870 - Pinned Build Script Backport Omnibus
  8. Pull Request 857 - Simplify Pinned Build Scripts
  9. Pull Request 811 - Pinned Build Script Changes

@kj4ezj kj4ezj force-pushed the zach-pinned-build branch from 3e3934b to baa6e05 Compare March 17, 2023 03:42
@kj4ezj kj4ezj changed the base branch from zach-lint to zach-install-deps March 17, 2023 06:47
@kj4ezj kj4ezj force-pushed the zach-pinned-build branch from baa6e05 to 729719b Compare March 17, 2023 07:03
@kj4ezj kj4ezj changed the title Pinned Builds in CI Pinned Build Script Changes + Restore libcurl4-openssl-dev Mar 17, 2023
@kj4ezj kj4ezj force-pushed the zach-install-deps branch from ae6ec74 to 7ec00d4 Compare March 20, 2023 17:43
@kj4ezj kj4ezj changed the title Pinned Build Script Changes + Restore libcurl4-openssl-dev Pinned Build Script Changes Mar 21, 2023
@kj4ezj kj4ezj mentioned this pull request Mar 21, 2023
@kj4ezj kj4ezj changed the base branch from zach-install-deps to main March 21, 2023 19:07
@kj4ezj kj4ezj changed the base branch from main to release/4.0 April 10, 2023 21:43
@spoonincode
Copy link
Member

Pinned build script has been removed, so closing this PR

@kj4ezj kj4ezj deleted the zach-pinned-build branch September 25, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants