-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinned Build Script Changes #811
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9049a6f
to
954c26c
Compare
954c26c
to
3e3934b
Compare
for Debian-family OSes
…rt if used externally).
3e3934b
to
baa6e05
Compare
This was referenced Mar 17, 2023
Closed
…allations from source
baa6e05
to
729719b
Compare
ae6ec74
to
7ec00d4
Compare
This was referenced Mar 21, 2023
Pinned build script has been removed, so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From issue 735, this pull request fixes the pinned build by returning the
libcurl4-openssl-dev
dependency.It also contains changes to the script output with the intention of making it easier to debug and easier to understand where in the process the script is. Mostly this means adding
echo
statements but, notably, I also switched fromwget
tocurl
becausewget
was throwing up in my terminal andcurl
gives us more control anyways. It is possiblewget
can be removed from the list of dependencies, but I did not remove it because I was not certain it was unused (for example, in the CMake).See Also
Pull Request 832 - Rollinstall_deps.sh
intopinned_build.sh
libcurl4-openssl-dev
README.md
Formatting