Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PH] Use EOSMechanics contract with Performance Test #713
[PH] Use EOSMechanics contract with Performance Test #713
Changes from 4 commits
1ca46a8
d35b2f9
06c418e
94d4b4b
96ae1ec
724ba6c
5a67397
e27ebfa
270ea09
8f75c30
074471b
3f191a9
fd0c702
97a8d12
b1ce271
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should do the same thing as the other CMakeLists.txt of eosio.wrap and eosio.token etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We likely want to submodule this in instead of copying it.
Not sure if we need to copy this license file out with other license files.
Thoughts on best way to use this? @arhag @spoonincode @wanderingbort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo, since we don't distribute the file any further than the builddir (that is, we neither include it in a package nor as part of
make install
), we probably don't need to do anything with the license besides just ensure it's there next to the source file(s) it pertains to. As you've done.As far as submodule vs not, I'm unsure. It does feel like a submodule might be more proper but then again it feels awfully heavy for something like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ClaytonCalabrese said he had to make minor modifications to it to work with our cmake setup. Probably the best course is to just copy it in as this PR has it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, if we've modified it that's probably best