[PH] Use EOSMechanics contract with Performance Test #713
Conversation
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
We likely want to submodule this in instead of copying it.
Not sure if we need to copy this license file out with other license files.
Thoughts on best way to use this? @arhag @spoonincode @wanderingbort
There was a problem hiding this comment.
imo, since we don't distribute the file any further than the builddir (that is, we neither include it in a package nor as part of make install), we probably don't need to do anything with the license besides just ensure it's there next to the source file(s) it pertains to. As you've done.
As far as submodule vs not, I'm unsure. It does feel like a submodule might be more proper but then again it feels awfully heavy for something like this.
There was a problem hiding this comment.
As far as submodule vs not, I'm unsure. It does feel like a submodule might be more proper but then again it feels awfully heavy for something like this.
@ClaytonCalabrese said he had to make minor modifications to it to work with our cmake setup. Probably the best course is to just copy it in as this PR has it.
There was a problem hiding this comment.
ah yeah, if we've modified it that's probably best
…est failures in doing so.
…mmas, set back assert in trx_generator main
… from merge. Fix printing of account type in json.
| @@ -0,0 +1 @@ | |||
| file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/contracts/ DESTINATION ${CMAKE_CURRENT_BINARY_DIR}/contracts/) | |||
There was a problem hiding this comment.
This should do the same thing as the other CMakeLists.txt of eosio.wrap and eosio.token etc
…nt for performance test. revert the reversion of the setupWallet change
A retooling was needed to enable EOS Mechanics to be used with the transaction generator. In addition, EOS mechanics was brought into the codebase. In cluster,
populateWalletandcreateAccountswere changed to allow them to be called multiple times in the same test, this is so the contract holder account can be set up prior to running the test.specifiedContractwas redesigned to better use the pre-existingAccounttype, and references to keys and account names are now based offaccountinstead. Custom contracts are enabled in performance_test_basic by passing theaccount-name,abi-file,wasm-file,contract-dir, anduser-trx-data-filealong the command line.This PR adds 2 new test runs,
performance_test_basic_ex_cpu_trx_specandperformance_test_basic_ex_ram_trx_spec, which run thecpu()andram()actions from EOS Mechanics in performance_test_basic.