Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2] Block-log leap-util subcommand refactoring #327

Merged
merged 4 commits into from
Oct 20, 2022
Merged

[3.2] Block-log leap-util subcommand refactoring #327

merged 4 commits into from
Oct 20, 2022

Conversation

vladtr
Copy link
Contributor

@vladtr vladtr commented Oct 14, 2022 •
edited
Loading

This PR addresses following issues:

  • flags and options made applicable to actual subcommands using them
  • "default" behavior of printing log changed to a subcommand print-log. Default handler of parent subcommand "block-log" eliminated
  • simplified and unified callbacks and error handling for return codes and exceptions
  • re-enabled (and tested) smoke-test subcommand
  • few other minor fixes

@vladtr vladtr changed the title [3,2] Block-log leap-util subcommand refactoring [3.2] Block-log leap-util subcommand refactoring Oct 14, 2022
@vladtr vladtr mentioned this pull request Oct 14, 2022
Closed
@vladtr vladtr linked an issue Oct 19, 2022 that may be closed by this pull request
Clean up block-log sub-command options in leap-util #282
Closed
@vladtr vladtr merged commit 8ef4d9a into release/3.2 Oct 20, 2022
@vladtr vladtr deleted the block-log-refactoring-32 branch October 20, 2022 17:02
@vladtr vladtr mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up block-log sub-command options in leap-util
2 participants
@vladtr @linh2931