Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Block-log leap-util subcommand refactoring #325

Closed
wants to merge 3 commits into from

Conversation

vladtr
Copy link
Contributor

@vladtr vladtr commented Oct 14, 2022

This PR addresses following issues:

  • flags and options made applicable to actual subcommands using them
  • "default" behavior of printing log changed to a subcommand print-log. Default handler of parent subcommand "block-log" eliminated
  • simplified and unified callbacks and error handling for return codes and exceptions
  • re-enabled (and tested) smoke-test subcommand
  • few other minor fixes

@vladtr vladtr linked an issue Oct 14, 2022 that may be closed by this pull request
@vladtr vladtr added this to the Leap 3.2.0-rc2 milestone Oct 14, 2022
@heifner
Copy link
Member

heifner commented Oct 14, 2022

@766C6164 should this target release/3.2?

@vladtr vladtr changed the title Block-log leap-util subcommand refactoring [main] Block-log leap-util subcommand refactoring Oct 14, 2022
@vladtr
Copy link
Contributor Author

vladtr commented Oct 14, 2022

@766C6164 should this target release/3.2?

Thank you! I added this for 3.2: #327

@vladtr vladtr removed this from the Leap 3.2.0-rc2 milestone Oct 14, 2022
@linh2931
Copy link
Member

You should discard this one. After #327 is approved, merge release/3.2 to main and create a new PR on main.

@vladtr vladtr closed this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up block-log sub-command options in leap-util
3 participants