[3.2] add more context to chainbase logging during loading and writing in heap or locked more #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 28, 2022
heifner
added a commit
that referenced
this pull request
Dec 2, 2022
…mand. Also greatly simplified the fork python script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when chainbase was used in heap or locked mode (modes where it preloads the entire DB), log statements were printed as
The lack of context on the progress logs was noted as a problem in eosnetworkfoundation/mandel#318
Now, add more context to the logs so they look like
Needs AntelopeIO/chainbase#2