Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log messages when loading/unloading state #318

Closed
matthewdarwin opened this issue May 27, 2022 · 4 comments
Closed

Improve log messages when loading/unloading state #318

matthewdarwin opened this issue May 27, 2022 · 4 comments

Comments

@matthewdarwin
Copy link

When loading or unloading state (startup, shutdown) and config database-map-mode = heap, then nodeos prints log messages like:

CHAINBASE: Preloading "state" database file, this could take a moment...
               1% complete...
               10% complete...
               18% complete...
               26% complete...
               34% complete...
               41% complete...

The % complete messages don't say what is loading or unloading making it harder for log file parsers to know what is going on as you need the context from the "first" line here.

Better would be something like:

Loading chainbase, 1% complete
Loading chainbase, 10% complete
@spoonincode
Copy link
Member

would be nice to figure out a clean way to get appbase & chainbase to participate in the standard logging mechanism 🤔

@heifner
Copy link
Member

heifner commented May 27, 2022

Why not just add dependence on fc to appbase & chainbase

@spoonincode
Copy link
Member

submodule hell is my first thought 😅 like wouldn't you have to be extra careful that the fc submodule is the same all across chainbase & appbase & mandel to ensure ODR satisfied?

@heifner
Copy link
Member

heifner commented May 27, 2022

Maybe via https://cmake.org/cmake/help/latest/module/FetchContent.html where you specify a mandel wide version of fc.

@stephenpdeos stephenpdeos moved this to Todo in ENF Engineering Jul 21, 2022
@spoonincode spoonincode self-assigned this Sep 28, 2022
@spoonincode spoonincode moved this from Todo to In Progress in ENF Engineering Sep 28, 2022
@spoonincode spoonincode moved this from In Progress to Reviewer Approved in ENF Engineering Sep 28, 2022
Repository owner moved this from Reviewer Approved to Done in ENF Engineering Sep 29, 2022
@spoonincode spoonincode removed their assignment Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants