-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve log messages when loading/unloading state #318
Comments
would be nice to figure out a clean way to get appbase & chainbase to participate in the standard logging mechanism 🤔 |
Why not just add dependence on fc to appbase & chainbase |
submodule hell is my first thought 😅 like wouldn't you have to be extra careful that the fc submodule is the same all across chainbase & appbase & mandel to ensure ODR satisfied? |
Maybe via https://cmake.org/cmake/help/latest/module/FetchContent.html where you specify a mandel wide version of fc. |
When loading or unloading state (startup, shutdown) and config
database-map-mode = heap
, then nodeos prints log messages like:The % complete messages don't say what is loading or unloading making it harder for log file parsers to know what is going on as you need the context from the "first" line here.
Better would be something like:
The text was updated successfully, but these errors were encountered: