Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Reenable verify_producer_schedule_after_instant_finality_activation #2187

Merged
merged 2 commits into from
Feb 2, 2024
Merged

IF: Reenable verify_producer_schedule_after_instant_finality_activation #2187

merged 2 commits into from
Feb 2, 2024

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Feb 2, 2024

As SIGSEGV was fixed by #2185, re-enable verify_producer_schedule_after_instant_finality_activation Boost unit test (disabled by #2176).

Resolved one of 6 tasks in #2175

@linh2931 linh2931 requested review from greg7mdp and heifner February 2, 2024 02:35
@linh2931 linh2931 changed the title IF: Reenable reenable verify_producer_schedule_after_instant_finality_activation IF: Reenable verify_producer_schedule_after_instant_finality_activation Feb 2, 2024
@ericpassmore
Copy link
Contributor

ericpassmore commented Feb 2, 2024 •
edited
Loading

Note:start
group: IF
category: TEST
summary: Reenable test to verify producer after Faster Finality is activated.
Note:end

@heifner heifner mentioned this pull request Feb 2, 2024
Closed
@linh2931 linh2931 merged commit 1e686a6 into hotstuff_integration Feb 2, 2024
26 checks passed
@linh2931 linh2931 deleted the reenable-producer_schedule_if_test branch February 2, 2024 15:48
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: TEST
summary: Re-enable tests for verifying producer schedule.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linh2931 @ericpassmore @greg7mdp @heifner