Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Temporarily disable failing tests #2176

Merged
merged 3 commits into from
Feb 1, 2024
Merged

IF: Temporarily disable failing tests #2176

merged 3 commits into from
Feb 1, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 31, 2024 •
edited
Loading

  • set_finalizer_test
  • verify_producer_schedule_after_instant_finality_activation
  • nodeos_short_fork_take_over_if_test
  • restart-scenarios-if-test-resync
  • auto_bp_peering_if_test
  • nodeos_high_transaction_if_lr_test

Note this requires commenting out all our instant-finality unittests.

#2175 will track adding them back.

@heifner heifner requested review from greg7mdp and linh2931 January 31, 2024 22:56
@heifner heifner added the OCI Work exclusive to OCI team label Feb 1, 2024
@heifner heifner merged commit 93ddc22 into hotstuff_integration Feb 1, 2024
26 checks passed
@heifner heifner deleted the disable-failing-tests branch February 1, 2024 01:11
@linh2931 linh2931 mentioned this pull request Feb 2, 2024
Merged
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: CHORE
summary: Temporarily disable failing tests.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heifner @ericpassmore @greg7mdp @linh2931