-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.1 -> main] Update cleos to return an error code on failed trx processing #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…similar to before --return-failure-trace was added.
…ome tests are expecting to find errors in the trace.
[3.1] Update cleos to return an error code on failed trx processing
[3.1] Bump version 3.1.1
heifner
commented
Sep 22, 2022
@@ -205,7 +205,8 @@ def checkDelayedOutput(popen, cmd, ignoreError=False): | |||
Utils.checkOutputFileWrite(start, cmd, output, error) | |||
if popen.returncode != 0 and not ignoreError: | |||
Utils.Print("ERROR: %s" % error) | |||
raise subprocess.CalledProcessError(returncode=popen.returncode, cmd=cmd, output=error) | |||
# for now just include both stderr and stdout in output, python 3.5+ supports both a stdout and stderr attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to address this comment in a follow-on PR. Plan on moving stdout
to output
and stderr
to stderr
. Then update all uses to use stderr
instead of output
; except for the one existing use that the stdout
was added for.
spoonincode
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leap 3.1 returns transaction failure traces by default.
EOSIO/eos 2.0
would instead throw an exception.The 3.1 release notes included the following:
This PR addresses the cleos non-zero return values for failed transaction execution. With this PR, cleos will parse the returned transaction traces and return a non-zero return value for transactions that failed to speculatively execute.
Before:
After:
Resolves #139
Merges #199 into
main
.