[3.1] Update cleos to return an error code on failed trx processing

[heifner]

Leap 3.1 returns transaction failure traces by default. EOSIO/eos 2.0 would instead throw an exception.
The 3.1 release notes included the following:

New command line options for cleos:

• --use-old-send-rpc
  • "Use old RPC /v1/chain/send_transaction, rather than new RPC /v1/chain/send_transaction2"
• -t,--return-failure-trace defaults to true use -t false for previous behavior
  • "Return partial traces on failed transactions"
  • Note: Automation which depends on cleos to return a non-zero value on transaction failure will instead need to parse the traces or use option -t false.

This PR addresses the cleos non-zero return values for failed transaction execution. With this PR, cleos will parse the returned transaction traces and return a non-zero return value for transactions that failed to speculatively execute.

Before:

$ ./cleos  push action  eosio.token transfer '{"from":"eosio","to":"testera11111","quantity":"0.0001 SYS","memo":"hi"}'
failed transaction: d19173082af2e0dee7d11a638adabc646f55b81364b923b71c6d467fbff30b76  <unknown> bytes  <unknown> us
error 2022-09-21T15:20:49.283 cleos     main.cpp:601                  print_result         ] soft_except->to_detail_string(): 3040003 tx_no_auths: Transaction should have at least one required authority
transaction must have at least one authorization
    {}
    nodeos  transaction_context.cpp:753 validate_referenced_accounts

$ echo $?
0

After:

$ ./cleos  push action  eosio.token transfer '{"from":"eosio","to":"testera11111","quantity":"0.0001 SYS","memo":"hi"}'
failed transaction: 1488c901f8d1952eae4fddd509758a639cabf5f1ea86967bf6215580c264f519  <unknown> bytes  <unknown> us
error 2022-09-21T15:20:42.847 cleos.3.1 main.cpp:575                  print_result         ] soft_except->to_detail_string(): 3040003 tx_no_auths: Transaction should have at least one required authority
transaction must have at least one authorization
    {}
    nodeos  transaction_context.cpp:753 validate_referenced_accounts

$ echo $?
3

Resolves #139

[spoonincode]

Do you need to check if processed is an object before get_object()ing it? You do the is_object() check for result & except. And a failure here with processed not being an object would be outside of the try block internal to this function.

[heifner]

Yes, that would be better. I copy/pasted from print_result which does not have that. I'll add the check.

[spoonincode]

what is the Python 3.5+ comment here getting at -- even Ubuntu 18 is using 3.6 so if there is a 3.5+ feature we should be able to use it

[heifner]

stderr was being placed in output. Python 3.5+ has both an output and a stderr. The better fix is to put stdout into output and stderr into stderr. However, output is used in 20+ places in many tests. I didn't want to make that big of a change in release/3.1. In main I plan to sperate out the stdout and stderr and update the 20+ usages of the CalledProcessError.

[spoonincode]

At this point we've established that except is an object. Do we really need to treat except as an optional type still?

[heifner]

No. Removed optional.