[3.1] Report account not found instead of boost unknown key error

[heifner]

/v1/chain/get_account was reporting a boost unknown key. Change error to account_query_exception to provide a better error message when an account does not exist.

Before:

$ ./cleos get account kevinheifner
error 2022-09-19T13:50:59.159 cleos     main.cpp:4121                 operator()           ] Failed with error: unspecified (0)
unknown key (boost::tuples::tuple<bool, eosio::chain::name, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>): (0 kevinheifner)

$ ./cleos --print-response get account kevinheifner
RESPONSE:
---------------------
{
  "code": 500,
  "message": "Internal Service Error",
  "error": {
    "code": 0,
    "name": "exception",
    "what": "unspecified",
    "details": [{
        "message": "unknown key (boost::tuples::tuple<bool, eosio::chain::name, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type, boost::tuples::null_type>): (0 kevinheifner)",
        "file": "http_plugin.cpp",
        "line_number": 516,
        "method": "handle_exception"
      }
    ]
  }
}
---------------------

After:

$ ./cleos get account kevinheifner
Error 3060002: Account Query Exception
Most likely, the given account doesn't exist in the blockchain.
Error Details:
Account not found: kevinheifner

$ ./cleos --print-response get account kevinheifner
RESPONSE:
---------------------
{
  "code": 500,
  "message": "Internal Service Error",
  "error": {
    "code": 3060002,
    "name": "account_query_exception",
    "what": "Account Query Exception",
    "details": [{
        "message": "Account not found: kevinheifner",
        "file": "chain_plugin.cpp",
        "line_number": 2430,
        "method": "get_account"
      }
    ]
  }
}
---------------------

On the server now:

debug 2022-09-19T15:14:17.623 nodeos    http_plugin.cpp:952           handle_exception     ] Exception while processing chain.get_account: 3060002 account_query_exception: Account Query Exception
Account not found: kevinheifner
    {"a":"kevinheifner"}
    nodeos  chain_plugin.cpp:2430 get_account
account: kevinheifner
    {"a":"kevinheifner"}
    nodeos  chain_plugin.cpp:2590 get_account

Guarded by debug level output.

Resolves #186

[spoonincode]

Is changing the error code and message for a response like this considering breaking? Is it possible someone is parsing the response for certain messages and this would change behavior?

[heifner]

Is changing the error code and message for a response like this considering breaking? Is it possible someone is parsing the response for certain messages and this would change behavior?

Maybe. @arhag ? If so, I can move this to 3.2.

[heifner]

Decided this was too much of a breaking change outside at least a 4.0 release as the error code and error message is modified by this change. It is possible and maybe likely that users are expecting the current error code and/or error string when the account does not exist. Closing with the plan that this along with other enhancements for the HTTP API will be made in future releases likely in a different namespace such as /v3/chain/get_account.