-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get_account fail case, RPC endpoint for is_valid_account #591
Labels
Comments
Related: #188 |
This looks like another request for a |
cmadh
pushed a commit
to cmadh/leap
that referenced
this issue
Jan 2, 2023
…OGH-590-shutdown-race [3.1] Fix race condition on trace_api_plugin shutdown
Alignment that we should verify this is still throwing a 500 error and if so, it should be updated to a 400 or 200 error. We do not plan to add an is_valid endpoint at this time. |
heifner
added a commit
that referenced
this issue
Mar 27, 2023
heifner
added a commit
that referenced
this issue
Mar 28, 2023
heifner
added a commit
that referenced
this issue
Mar 28, 2023
heifner
added a commit
that referenced
this issue
Apr 3, 2023
heifner
added a commit
that referenced
this issue
Apr 4, 2023
Return 400 http error for unknown account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Use case:
Any app creating a user account must check if the account exists.
Current solution:
Calling get_account - get_account is relatively expensive when it succeeds but assumes that the account passed in is valid.
get_account does not handle non-existing account well: It crashes with a 500 internal server error, which might be a bug and exploitable by malicious actors.
Fixing get_account is likely also a good idea, so it fails gracefully on a non-existing account
This is a fail case trace:
The text was updated successfully, but these errors were encountered: