Fixes file out and show latest #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doVisualize(s) method took a string that had a type and a parameter, like "XML: /foo/bar..". There was a public method setLatestInstance(s) that sets the parameter part. However, that meant that we could not remember the latest if it wasn't XML. The doVisualize(s) was the central dispatcher for visualization and called from many places. The doVisualize(s) now takes an _optionally_ typed argument. If it is not typed, we assume XML. So now can we set a typed string via setLatestInstance(s). When we create an output file as is now supported by the solver architecture, we safe it as "CNF: /...". So when we hit show latest instance, we get the file. Ugly as hell ... Fixes AlloyTools#273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The doVisualize(s) method took a string that had
a type and a parameter, like "XML: /foo/bar..". There was a public method setLatestInstance(s) that sets the parameter part. However, that meant that we could not remember the latest if it wasn't XML. The doVisualize(s) was the central dispatcher for visualization and called from many places.
The doVisualize(s) now takes an optionally typed argument. If it is not typed, we assume XML. So now can we set a typed string via setLatestInstance(s).
When we create an output file as is now supported by the solver architecture, we safe it as "CNF: /...". So when we hit show latest instance, we get the file.
Ugly as hell ...
Fixes #273