Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show should open the code window in the "output" solvers of the forthcoming release #273

Closed
grayswandyr opened this issue May 2, 2024 · 0 comments · Fixed by #276
Closed
Assignees
Milestone

Comments

@grayswandyr
Copy link
Contributor

The forthcoming release contains 3 "solvers" to output code: CNF, Kodkod and electrod.elo (please add the string "output" in this entry too), which is great. However, clicking the Show button doesn't open the code view but a foprmerly computed instance. Please change this so that a click on Show opens the code view (like clicking on the "File written to...." hyperlink in the right pane).

@grayswandyr grayswandyr added this to the A6.1 milestone May 2, 2024
pkriens added a commit to pkriens/org.alloytools.alloy that referenced this issue May 14, 2024
The doVisualize(s) method took a string that had
a type and a parameter, like "XML: /foo/bar..". There
was a public method setLatestInstance(s) that sets
the parameter part. However, that meant that we could
not remember the latest if it wasn't XML. The doVisualize(s)
was the central dispatcher for visualization and called
from many places.

The doVisualize(s) now takes an _optionally_ typed
argument. If it is not typed, we assume XML. So now
can we set a typed string via setLatestInstance(s).

When we create an output file as is now supported by
the solver architecture, we safe it as "CNF: /...".
So when we hit show latest instance, we get the file.

Ugly as hell ...

Fixes AlloyTools#273
pkriens added a commit that referenced this issue May 14, 2024
The doVisualize(s) method took a string that had
a type and a parameter, like "XML: /foo/bar..". There
was a public method setLatestInstance(s) that sets
the parameter part. However, that meant that we could
not remember the latest if it wasn't XML. The doVisualize(s)
was the central dispatcher for visualization and called
from many places.

The doVisualize(s) now takes an _optionally_ typed
argument. If it is not typed, we assume XML. So now
can we set a typed string via setLatestInstance(s).

When we create an output file as is now supported by
the solver architecture, we safe it as "CNF: /...".
So when we hit show latest instance, we get the file.

Ugly as hell ...

Fixes #273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants