chore(cosmic-swingset): repl.js imports getInterfaceOf/etc

[warner]

.. rather than being given them on vatPowers, since those are going away.

refs #2637

@michaelfig I changed stringify to stop accepting a getInterfaceOf argument because eslint complained about the shadowed name. I didn't see any external importers of the file within cosmic-swingset/, so I removed the export. If there are any external importers of this file, they'll need to be updated for the new signature (I removed the argument from the middle, which is always troublesome). I figured a "cannot import" error would be more obvious than whatever would happen when one argument gets confused for another. As part of your review, please think about whether there are any other importers.

[warner]

Ah, well apparently dapp-svelte-wallet uses it.

It looks like Debug.svelte only has a two-argument call to stringify(), so this change shouldn't affect it. I guess I'll re-enable the export and just hope that nothing else imports it. It's challenging to be confident about that.. the use of deep-imports makes me nervous.

[michaelfig]

I don't see the need to change the stringify API. Agreed that this could be cleaned up sometime, but I'm hesitant to make breaking changes without renaming the function.

[michaelfig]

Why make an incompatible change to the API? Just rename the argument to avoid the shadowing, and default its value as in:

  gio = getInterfaceOf,

and then use gio within the stringify function.

[warner]

Aye. I generally like to delete code when it's no longer needed, but I agree it's quicker and only slightly ugly to leave this argument in place.

[michaelfig]

LGTM!