remove Remotable/getInterfaceOf from vatPowers #2637
Assignees
Labels
Comments
warner
added a commit
that referenced
this issue
Mar 14, 2021
.. rather than being given them on `vatPowers`, since those are going away. refs #2637
warner
added a commit
that referenced
this issue
Mar 14, 2021
Vat code should import these three from `@agoric/marshal` rather than pulling them from `vatPowers`. closes #2637
warner
added a commit
that referenced
this issue
Mar 14, 2021
Vat code should import these three from `@agoric/marshal` rather than pulling them from `vatPowers`. closes #2637
warner
added a commit
that referenced
this issue
Mar 15, 2021
.. rather than getting them from `vatPowers`, since those are going away. refs #2637
warner
added a commit
that referenced
this issue
Mar 15, 2021
Vat code should import these three from `@agoric/marshal` rather than pulling them from `vatPowers`. closes #2637
warner
added a commit
that referenced
this issue
Mar 15, 2021
.. rather than getting them from `vatPowers`, since those are going away. refs #2637
warner
added a commit
that referenced
this issue
Mar 15, 2021
Vat code should import these three from `@agoric/marshal` rather than pulling them from `vatPowers`. closes #2637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
Far/Remotable/getInterfaceOfcan be correctly imported from@agoric/marshal: they no longer use a WeakMap, so the code that appliesFarcan safely import a different copy ofmarshalthan the code that queriespassStyleOforgetInterfaceOf.As a result, we no longer need to supply vats with these functions through the
vatPowersobject, and we should remove them.This will change swingset's
src/kernel/vatManager/manager-local.js,supervisor-subprocess-xsnap.js, and others in that directory. I don't think we have any unit tests that still exercise the presence ofvatPowers.getInterfaceOf(those should all have been converted to imports by now), but we should double check. We should also do a quick scan of the rest of the tree for references tovatPowers, orFar/getInterfaceOfthat don't come from an import (maybe build a--list-files-without-matcheswith all the.jsfiles that lack an import of@agoric/marshal, then search that list for uses ofFar/etc).The text was updated successfully, but these errors were encountered: