Turn on strict compilation mode #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awentzel
approved these changes
Jul 23, 2024
packages/adaptive-ui-designer-figma-plugin/src/ui/components/token-glyph/index.ts
Outdated
Show resolved
Hide resolved
nicholasrice
approved these changes
Jul 23, 2024
51276a2 to
5a8af4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Paving the way to make future updates easier. Turned on
strictacross the entire repo.Reviewer Notes
The FAST web components require a lot of the observables and attributes to be optional and have a default value. I believe this PR makes the behavior more correct in what may actually happen, and thus some added checks make them more resilient.
Test Plan
Tested all leaf modules.
Checklist
General