Review comments

Adaptive-Web-Community · Jul 25, 2024 · 51276a2 · 51276a2
1 parent 01b35a6
commit 51276a2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/packages/adaptive-ui-designer-figma-plugin/src/ui/components/token-glyph/index.ts b/packages/adaptive-ui-designer-figma-plugin/src/ui/components/token-glyph/index.ts
@@ -121,6 +121,8 @@ const params = {
     part: ".swatch",
 };
 
+const PLACEHOLDER_COLOR = "#ff00ff";
+
 @customElement({
     name: "designer-token-glyph",
     template,
@@ -137,11 +139,11 @@ export class TokenGlyph extends FASTElement {
     public value: string | "none" = "none";
     protected valueChanged(prev: string, next: string) {
         const color = parse(next);
-        this.valueColor = formatHex8(color) || "#ff00ff";
+        this.valueColor = formatHex8(color) || PLACEHOLDER_COLOR;
     }
 
     @observable
-    public valueColor: string = "#ff00ff";
+    public valueColor: string = PLACEHOLDER_COLOR;
 
     @observable
     public styles?: Styles;

diff --git a/packages/adaptive-ui-explorer/src/state.ts b/packages/adaptive-ui-explorer/src/state.ts
@@ -15,18 +15,20 @@ export interface State {
     showSwatches: boolean;
 }
 
+const PLACEHOLDER_COLOR = "#ff00ff";
+
 export class DefaultState implements State {
     @observable
     public componentType: ComponentType = ComponentType.backplate;
 
     @observable
-    public neutralColor: string = "#ff00ff";
+    public neutralColor: string = PLACEHOLDER_COLOR;
 
     @observable
-    public accentColor: string = "#ff00ff";
+    public accentColor: string = PLACEHOLDER_COLOR;
 
     @observable
-    public highlightColor: string = "#ff00ff";
+    public highlightColor: string = PLACEHOLDER_COLOR;
 
     @observable
     public showOnlyLayerBackgrounds: boolean = true;