Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Notification event to relevent view #2796

Merged

Conversation

Ayush8923
Copy link
Contributor

@Ayush8923 Ayush8923 commented Jan 21, 2025

closes: #2754

Visible/Frontend Changes

  • Update the notification redirection logic.

@Ayush8923 Ayush8923 changed the base branch from master to feat/1055_notifications-final January 21, 2025 06:45
@Ayush8923 Ayush8923 self-assigned this Jan 21, 2025
Copy link
Contributor

Deployed to https://pr-2796.aam-digital.net/

@Ayush8923 Ayush8923 marked this pull request as ready for review January 21, 2025 09:53
@Ayush8923 Ayush8923 requested a review from sleidig January 21, 2025 09:53
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayush8923 , @tomwwinter I have generalized the NotificationEvent interface to give us more flexibility, identifying the exact entity that triggered an event (if applicable)

@sleidig sleidig merged commit eb8ed44 into feat/1055_notifications-final Jan 23, 2025
12 checks passed
@sleidig sleidig deleted the update/notification-to-relevant-view branch January 23, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

click on Notification entry navigates to the relevant view (e.g. details of the changed entity)
2 participants