Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click on Notification entry navigates to the relevant view (e.g. details of the changed entity) #2754

Closed
sleidig opened this issue Dec 27, 2024 · 0 comments · Fixed by #2786 or #2796
Closed
Assignees
Milestone

Comments

@sleidig
Copy link
Member

sleidig commented Dec 27, 2024

The basic functionality is already implemented in PR #2738.
To make this less error-prone, we should maybe dynamically generate the actionUrl in the NotificationEvent class based on the notificationType , e.g. for entity_change the link can be generated by looking up the current route for that entityType instead of hard-coding the link into each NotificationEvent document (any maybe leading into nothing if the admin changes the route for that entity type).

@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Dec 27, 2024
@sleidig sleidig added this to the Notifications milestone Dec 27, 2024
@sleidig sleidig moved this from Triage / Analysis to Planned (current "sprint") in All Tasks & Issues Dec 27, 2024
@Ayush8923 Ayush8923 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Jan 13, 2025
@Ayush8923 Ayush8923 moved this from In Progress to Planned (current "sprint") in All Tasks & Issues Jan 13, 2025
@Ayush8923 Ayush8923 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Jan 14, 2025
@Ayush8923 Ayush8923 linked a pull request Jan 14, 2025 that will close this issue
1 task
@Ayush8923 Ayush8923 moved this from In Progress to Technical Review in All Tasks & Issues Jan 17, 2025
@tomwwinter tomwwinter moved this from Technical Review to Functional Review in All Tasks & Issues Jan 19, 2025
@tomwwinter tomwwinter moved this from Functional Review to Done in All Tasks & Issues Jan 20, 2025
@sleidig sleidig moved this from Done to Technical Review in All Tasks & Issues Jan 20, 2025
@sleidig sleidig moved this from Technical Review to In Progress in All Tasks & Issues Jan 20, 2025
@sleidig sleidig moved this from In Progress to Technical Review in All Tasks & Issues Jan 21, 2025
@sleidig sleidig moved this from Technical Review to In Progress in All Tasks & Issues Jan 21, 2025
@Ayush8923 Ayush8923 moved this from In Progress to Technical Review in All Tasks & Issues Jan 21, 2025
@sleidig sleidig closed this as completed Jan 23, 2025
@github-project-automation github-project-automation bot moved this from Technical Review to Done in All Tasks & Issues Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
2 participants