Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditAssetCommand #95

Merged

Conversation

fivetran-tangyetong
Copy link

Add skeleton code for EditAssetCommand

Continue with tests for EditAssetCommand and undo command

Add skeleton code for EditAccessCommand

Continue with tests
Assets could not be edited

Assets can now be edited and relevant people holding the assets will get updated accordingly
Checkstyle errors for new edita command
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 86.84211% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 76.21%. Comparing base (1675f9c) to head (4dbeecc).

Files Patch % Lines
...seedu/address/logic/commands/EditAssetCommand.java 78.94% 5 Missing and 3 partials ⚠️
...java/seedu/address/logic/commands/CommandType.java 50.00% 1 Missing ⚠️
...java/seedu/address/model/person/fields/Assets.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     75.70%   76.21%   +0.50%     
- Complexity      427      450      +23     
============================================
  Files            70       71       +1     
  Lines          1379     1442      +63     
  Branches        111      119       +8     
============================================
+ Hits           1044     1099      +55     
- Misses          301      306       +5     
- Partials         34       37       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fivetran-tangyetong and others added 6 commits March 20, 2024 15:48
EditAssetCommand did not have any tests

Two tests were added to check simple usage
Expanded test coverage to include boundary conditions and invalid scenarios.
Line was added between tests
Add more coverage for EditAssetCommand
Code coverage insufficient for tests

Add more tests for EditAssetCommand
@aureliony aureliony linked an issue Mar 20, 2024 that may be closed by this pull request
@aureliony aureliony added this to the v1.2 milestone Mar 20, 2024
@aureliony aureliony marked this pull request as draft March 20, 2024 13:28
@bryanyee33 bryanyee33 marked this pull request as ready for review March 20, 2024 15:51
Copy link

@yisiox yisiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but keep in view refactor how Asset works. Closes #13

@yisiox yisiox merged commit 30a1d9e into AY2324S2-CS2103T-W12-3:master Mar 20, 2024
5 checks passed
aureliony pushed a commit that referenced this pull request Apr 15, 2024
Update AddOrderCommand and DeleteOrderCommand msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit contacts, tags and assets
5 participants