-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EditAssetCommand
#95
Add EditAssetCommand
#95
Conversation
Add skeleton code for EditAccessCommand Continue with tests
Assets could not be edited Assets can now be edited and relevant people holding the assets will get updated accordingly
f8119bb
to
28156c2
Compare
Checkstyle errors for new edita command
28156c2
to
826eaaf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
============================================
+ Coverage 75.70% 76.21% +0.50%
- Complexity 427 450 +23
============================================
Files 70 71 +1
Lines 1379 1442 +63
Branches 111 119 +8
============================================
+ Hits 1044 1099 +55
- Misses 301 306 +5
- Partials 34 37 +3 ☔ View full report in Codecov by Sentry. |
EditAssetCommand did not have any tests Two tests were added to check simple usage
Expanded test coverage to include boundary conditions and invalid scenarios.
Line was added between tests
Add more coverage for EditAssetCommand
…o add-edit-asset
3d79429
to
6cc6c26
Compare
Code coverage insufficient for tests Add more tests for EditAssetCommand
6cc6c26
to
db1c999
Compare
Fix EditAssetCommand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but keep in view refactor how Asset works. Closes #13
Update AddOrderCommand and DeleteOrderCommand msg
Add skeleton code for
EditAssetCommand
Continue with tests for
EditAssetCommand
andundo
command