Skip to content

Commit

Permalink
Adhere to checkstyle requirements
Browse files Browse the repository at this point in the history
Checkstyle errors for new edita command
  • Loading branch information
fivetran-tangyetong committed Mar 20, 2024
1 parent 4066e2a commit 28156c2
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 16 deletions.
25 changes: 15 additions & 10 deletions src/main/java/seedu/address/logic/commands/EditAssetCommand.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
package seedu.address.logic.commands;

import static java.util.Objects.requireNonNull;
import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT;
import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS;
import static seedu.address.model.person.fields.Name.PREFIX_NAME;

import java.util.List;
import java.util.Objects;

import seedu.address.commons.util.CollectionUtil;
import seedu.address.commons.util.ToStringBuilder;
import seedu.address.logic.Messages;
Expand All @@ -10,15 +18,12 @@
import seedu.address.model.Model;
import seedu.address.model.asset.Asset;
import seedu.address.model.person.Person;
import seedu.address.model.person.fields.*;

import java.util.List;
import java.util.Objects;

import static java.util.Objects.requireNonNull;
import static seedu.address.logic.Messages.MESSAGE_INVALID_COMMAND_FORMAT;
import static seedu.address.model.Model.PREDICATE_SHOW_ALL_PERSONS;
import static seedu.address.model.person.fields.Name.PREFIX_NAME;
import seedu.address.model.person.fields.Address;
import seedu.address.model.person.fields.Assets;
import seedu.address.model.person.fields.Email;
import seedu.address.model.person.fields.Name;
import seedu.address.model.person.fields.Phone;
import seedu.address.model.person.fields.Tags;

/**
* Edits the details of an asset in the address book.
Expand Down Expand Up @@ -61,7 +66,7 @@ public String execute(Model model) throws CommandException {
throw new CommandException(Messages.MESSAGE_INVALID_ASSET_DISPLAYED);
}

for(Person p: lastShownList) {
for (Person p: lastShownList) {
if (p.hasAsset(assetToEdit)) {
Person editedPersonWithAsset = createEditedPersonWithAsset(assetToEdit, p, editAssetDescriptor);
model.setPerson(p, editedPersonWithAsset);
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/seedu/address/logic/util/ArgumentMultimap.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package seedu.address.logic.util;

import static seedu.address.model.person.fields.Assets.PREFIX_ASSET;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand All @@ -10,8 +12,6 @@
import seedu.address.logic.Messages;
import seedu.address.model.person.fields.Prefix;

import static seedu.address.model.person.fields.Assets.PREFIX_ASSET;

/**
* Stores mapping of prefixes to their respective arguments.
* Each key may be associated with multiple argument values.
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/seedu/address/logic/util/ArgumentTokenizer.java
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
package seedu.address.logic.util;

import static seedu.address.model.person.fields.Assets.PREFIX_ASSET;
import static seedu.address.model.person.fields.Name.PREFIX_NAME;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;

import seedu.address.model.person.fields.Prefix;

import static seedu.address.model.person.fields.Assets.PREFIX_ASSET;
import static seedu.address.model.person.fields.Name.PREFIX_NAME;

/**
* Tokenizes arguments string of the form: {@code preamble <prefix>value <prefix>value ...}<br>
* e.g. {@code some preamble text t/ 11.00 t/12.00 k/ m/ July} where prefixes are {@code t/ k/ m/}.<br>
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/seedu/address/model/person/fields/Assets.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
public class Assets implements Field {

public static final Prefix PREFIX_ASSET = new Prefix("A/");
public Set<Asset> assets;
private Set<Asset> assets;

/**
* Constructs a new {@code Assets} from a list of assets.
Expand Down Expand Up @@ -56,6 +56,11 @@ public boolean contains(Asset asset) {
return assets.contains(asset);
}

/**
* Changes name of asset.
* @param assetToEdit asset to be edited
* @param newAsset new asset name
*/
public void update(Asset assetToEdit, Asset newAsset) {
assets = assets.stream()
.map(asset -> asset.equals(assetToEdit) ? newAsset : asset)
Expand Down

0 comments on commit 28156c2

Please sign in to comment.